Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choose File doesn't work for write component #9984

Closed
AdRiley opened this issue May 17, 2024 · 3 comments · Fixed by #10047
Closed

Choose File doesn't work for write component #9984

AdRiley opened this issue May 17, 2024 · 3 comments · Fixed by #10047
Assignees
Labels
--bug Type: bug -gui p-high Should be completed in the next sprint
Milestone

Comments

@AdRiley
Copy link
Member

AdRiley commented May 17, 2024

Choose File doesn't work for write component if the file doesn't exist (which is common as I am about to write it)

image

@AdRiley AdRiley added p-high Should be completed in the next sprint --bug Type: bug -gui labels May 17, 2024
@AdRiley AdRiley added this to the Beta Release milestone May 17, 2024
@farmaazon
Copy link
Contributor

Perhaps there should be some configuration from the engine, when we want to allow only existing files.

But now let's just always accept any file name.

@farmaazon farmaazon self-assigned this May 23, 2024
@mergify mergify bot closed this as completed in #10047 May 24, 2024
mergify bot pushed a commit that referenced this issue May 24, 2024
Fixes #9984

Added a flag to `File_Browse` widget configuration specifying if we require an existing file. Also, the FileBrowserWidget will match against all "Writable_File", also displaying Save dialog.
@enso-bot
Copy link

enso-bot bot commented May 24, 2024

Adam Obuchowicz reports a new STANDUP for yesterday (2024-05-23):

Progress: Fixed the problem of file browser for write: we should use "save" dialog, not "open" one. Added configuration to libs specifying if non-existing files are allowed. It should be finished by 2024-05-27.

Next Day: Next day I will be working on the same task. I was asked for making file browser show the currently selected path on open.

@enso-bot
Copy link

enso-bot bot commented May 24, 2024

Adam Obuchowicz reports a new STANDUP for today (2024-05-24):

Progress: Opened a PR with default path being set in File Browser. Also investigated and (hopefully) fixed a recurring failure of our e2e tests. Cleaned up CI backlog a bit It should be finished by 2024-05-27.

Next Day: Next day I will be working on the #9828 task. Go back to tooltips, probably.

MrFlashAccount pushed a commit that referenced this issue May 25, 2024
Fixes #9984

Added a flag to `File_Browse` widget configuration specifying if we require an existing file. Also, the FileBrowserWidget will match against all "Writable_File", also displaying Save dialog.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--bug Type: bug -gui p-high Should be completed in the next sprint
Projects
Status: 🗄️ Archived
Development

Successfully merging a pull request may close this issue.

2 participants