Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don’t copy final array in Vector.build #9989

Open
GregoryTravis opened this issue May 17, 2024 · 0 comments
Open

Don’t copy final array in Vector.build #9989

GregoryTravis opened this issue May 17, 2024 · 0 comments
Assignees
@GregoryTravis
Labels
-libs Libraries: New libraries to be implemented p-low Low priority

Comments

@GregoryTravis
Copy link
Contributor

Vector.build has control over the scope of the builder, so it is safe to skip the copy at the end in .to_vector.

However, to avoid leaking unused memory, we will also change the array builder's resizer to be min(4/3 x, x + 4192).
@GregoryTravis GregoryTravis added p-low Low priority -libs Libraries: New libraries to be implemented labels May 17, 2024
@GregoryTravis GregoryTravis self-assigned this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GregoryTravis GregoryTravis

Labels
-libs Libraries: New libraries to be implemented p-low Low priority
Projects
Issues Board
Status: 📤 Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GregoryTravis