Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VHDS in Route configuration does not support ADS #34122

Open
rettuna opened this issue May 13, 2024 · 2 comments
Open

VHDS in Route configuration does not support ADS #34122

rettuna opened this issue May 13, 2024 · 2 comments
Labels

Comments

@rettuna
Copy link

rettuna commented May 13, 2024

Title: VHDS in Route configuration does not support ads

Description:
I have only an Incremental: AggregatedDiscoveryService.DeltaAggregatedResources server configured. I want the envoy to pull the virtual hosts using the ADS. But I get this error

err:vhds: only 'DELTA_GRPC' is supported as an api_type.

My config

{
		"name": "myrouteconfig0",
		"vhds": {
			"config_source": {
				"ads": {}
			}
		}
	}

If I change the config to use DELTA_GRPC then envoy doesn't use the ADS RPC to query virtual hosts and expects an incremental VHDS host to listen for Virtual host requests.

@rettuna rettuna added the triage Issue requires triage label May 13, 2024
@ravenblackx ravenblackx changed the title VHDS in Route configuration does not support ads VHDS in Route configuration does not support ADS May 14, 2024
@ravenblackx ravenblackx added area/xds and removed triage Issue requires triage labels May 14, 2024
@ravenblackx
Copy link
Contributor

@dmitri-d or @htuch maybe knows stuff about vhds.

@htuch
Copy link
Member

htuch commented May 15, 2024

#12742 is the explanation I think, @dmitri-d to confirm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants