Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing f prefix on f-strings #3414

Closed
code-review-doctor opened this issue Apr 23, 2022 · 1 comment · Fixed by #3415
Closed

Missing f prefix on f-strings #3414

code-review-doctor opened this issue Apr 23, 2022 · 1 comment · Fixed by #3415
Labels
stale

Comments

@code-review-doctor
Copy link
Contributor

Some strings looks like they're meant to be f-strings but are missing the f prefix meaning variable interpolation won't happen.

esphome/esphome/components/esp32/gpio.py

Line 110 in 757b987

raise cv.Invalid("Unsupported ESP32 variant {variant}")

esphome/esphome/components/esp32/gpio.py

Line 124 in 757b987

raise cv.Invalid("Unsupported ESP32 variant {variant}")

I found this issue automatically. I'm a bot. Beep Boop 🦊. See other issues I found in your repo here
@code-review-doctor code-review-doctor mentioned this issue Apr 24, 2022
Merged
@github-actions
Copy link
Contributor

#430

@github-actions github-actions bot added the stale label Apr 25, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Missing f prefix on f-strings fix code-review-doctor/esphome
1 participant
@code-review-doctor