Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

response_size (Required): Number of bytes of the response #5589

Closed
jansendup opened this issue Oct 23, 2023 · 1 comment
Closed

response_size (Required): Number of bytes of the response #5589

jansendup opened this issue Oct 23, 2023 · 1 comment
Labels

Comments

@jansendup
Copy link

The documentation of the response_size indicates that this field should limit the size of the response:

response_size (Required): Number of bytes of the response

However when looking at the parse_and_publish implementation it is clear that the response size is not limited: https://github.com/esphome/esphome/blob/e3fbf54a1aafad77ab3125855f21607ed35be74d/esphome/components/modbus_controller/text_sensor/modbus_textsensor.cpp#L16C29-L16C43

I suspect the author forgot to decrement the max_items variable for each response character processed.

@github-actions
Copy link
Contributor

#430

@github-actions github-actions bot added the stale label Oct 25, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant