We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The documentation of the response_size indicates that this field should limit the size of the response:
response_size (Required): Number of bytes of the response
However when looking at the parse_and_publish implementation it is clear that the response size is not limited: https://github.com/esphome/esphome/blob/e3fbf54a1aafad77ab3125855f21607ed35be74d/esphome/components/modbus_controller/text_sensor/modbus_textsensor.cpp#L16C29-L16C43
parse_and_publish
I suspect the author forgot to decrement the max_items variable for each response character processed.
max_items
The text was updated successfully, but these errors were encountered:
#430
Sorry, something went wrong.
No branches or pull requests
The documentation of the response_size indicates that this field should limit the size of the response:
However when looking at the
parse_and_publish
implementation it is clear that the response size is not limited: https://github.com/esphome/esphome/blob/e3fbf54a1aafad77ab3125855f21607ed35be74d/esphome/components/modbus_controller/text_sensor/modbus_textsensor.cpp#L16C29-L16C43I suspect the author forgot to decrement the
max_items
variable for each response character processed.The text was updated successfully, but these errors were encountered: