Can't build a Docker image due to pnpm

[dhalenok]

It seems like pnpm was introduced recently with #6148 / #6155 which is breaking the docker build process.

#18 [production 2/4] RUN { [ -z "ep_user_displayname ep_openid_connect" ] ||       pnpm install --no-save --legacy-peer-deps ep_user_displayname ep_openid_connect; } &&     src/bin/installDeps.sh &&     rm -rf ~/.npm
#18 sha256:f6b8b9a942d5d4cb514befff1e74854decefe7dfb0e8f86afc3a3d667e288ad9
#18 0.825  ERROR  Unknown option: 'legacy-peer-deps'
#18 0.825 Did you mean 'strict-peer-dependencies'? Use "--config.unknown=value" to force an unknown option.
#18 0.826 For help, run: pnpm help add
#18 ERROR: executor failed running [/bin/sh -c { [ -z "${ETHERPAD_PLUGINS}" ] ||       pnpm install --no-save --legacy-peer-deps ${ETHERPAD_PLUGINS}; } &&     src/bin/installDeps.sh &&     rm -rf ~/.npm]: exit code: 1

If I change the option from legacy-peer-deps to strict-peer-dependencies, there's a different error:

#18 [production 2/4] RUN { [ -z "ep_user_displayname ep_openid_connect" ] ||       pnpm install --no-save --strict-peer-dependencies ep_user_displayname ep_openid_connect; } &&     src/bin/installDeps.sh &&     rm -rf ~/.npm
#18 sha256:48a75e8d03e65d7a734640dca0f31e2fc68e9126f4ee8cd144a71c0f8244530e
#18 0.815  ERR_PNPM_OPTION_NOT_SUPPORTED  The "add" command currently does not support the no-save option
#18 ERROR: executor failed running [/bin/sh -c { [ -z "${ETHERPAD_PLUGINS}" ] ||       pnpm install --no-save --strict-peer-dependencies ${ETHERPAD_PLUGINS}; } &&     src/bin/installDeps.sh &&     rm -rf ~/.npm]: exit code: 1

I've done some more research and found out that the image will be built successfully if plugins are not specified.

[SamTV12345]

Hi, could you please try again? I think @JannikStreek fixed it with the last commit. Indeed --no-save and --strict-peer-dependencies aren't pnpm commands.

[dhalenok]

Thanks, it seems to be working better now.

As a suggestion, it might be worth to add another test case for building docker images with plugins.