New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"ep_openid_connect" plugin work with v2.0.x? #6330
Comments
It is fixed in ep_openid_connect v3.0.7 |
@SamTV12345 Thanks for the fix! I faced the same error too, I have upgraded ep_openid_connect to 3.0.7, but I still seemed to be getting the same error.
I am running etherpad with docker. And I checked the installed packages and the following appears to be happening:
I found out that Could Etherpad's plugin mechanism of 2.0.x not work properly if there are version conflicts in the packages it depends on? |
Oh that is a bummer. It's the client. I opened a pr over there that bumps the LRU cache to version 10. Then I can do a final update of the openid-client and it should work again panva/node-openid-client#674 |
Thank you for making the Pull Request on node-openid-client. Such version conflicts seem to occur in several other npm packages. (For example, in my plugin ep_kodama, openai-node seemed to contain such a conflict. yacchin1205/ep_kodama#1 ) |
I agree we need to find a more sophisticated way to store plugins. The question is only how. If you can think about a solution for this problem that would be great. I haven't found a solution on how to tell node that there is an alternative path in plugin_packages for that |
Thanks for the reply. I will try to improve this behavior. |
Is there any news on a fix for this error? |
I just published the fix. Now I noticed that the node-live-plugin manger has some issues with other registries as I published the patched version of openid-client on jsr https://jsr.io/@etherpad/node-openid-client/publish . I'll try to come up with a solution tomorrow. |
Oh wow thank you so much!! Etherpad was the last bit of infrastructure I wanted to include in my SSO network and tuesday the first users are coming in, hugely appreciate your work!!! |
FYI I am preparing code for improvements to live-plugin-manager. (Branch https://github.com/yacchin1205/live-plugin-manager/tree/feature/version-management ) |
I have submitted a Pull Request for live-plugin-manager. If merged, using the modified live-plugin-manager and making minor fixes to etherpad-lite should resolve this issue. |
The pull request for live-plugin-manager has been merged, and I will submit a pull request here when new version of the live-plugin-manager is published! |
Awesome did you ask him for a new release :) ? |
Yes 😄 It may be released in the near future. |
Now that the new version of live-plugin-manager has been released! I am working on a revised version and testing it. I believe the Pull Request will be available in the next few days. https://github.com/yacchin1205/etherpad-lite/tree/feature/upgrade-live-plugin-manager-1.0.0 |
Could you advise if the
suggested plugin
"ep_openid_connect" is still working with v2.0.x?I get the following error in the etherpad-lite log, openid connect plugin doesn't seem to work.
Ethepad-lite version: 2.0.2 (it seems all 2.0.x affected)
The text was updated successfully, but these errors were encountered: