Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mistral Instruct LLM doesn#t use chat template #13481

Open
martenmueller00 opened this issue May 7, 2024 · 1 comment
Open

Mistral Instruct LLM doesn#t use chat template #13481

martenmueller00 opened this issue May 7, 2024 · 1 comment
Labels
bug Bugs and behaviour differing from documentation feat/llm Feature: LLMs (incl. spacy-llm)

Comments

@martenmueller00
Copy link

martenmueller00 commented May 7, 2024

In the implementation of the mistral LLM connection an attribute is created which checks if the Instruct model version was selected. This check fails, as it is checked if lowercase "instruct" is in the model name. However, it should be checked for "Instruct", otherwise the attribute is always false and the wrong chat template is used.

Info about spaCy

  • spaCy version: 3.7.4
  • Platform: Linux-6.5.13-1-pve-x86_64-with-glibc2.35
  • Python version: 3.10.12
@svlandeg svlandeg added bug Bugs and behaviour differing from documentation feat/llm Feature: LLMs (incl. spacy-llm) labels May 15, 2024
@svlandeg
Copy link
Member

Thanks for the report! We'll look into this 🕵️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs and behaviour differing from documentation feat/llm Feature: LLMs (incl. spacy-llm)
Projects
None yet
Development

No branches or pull requests

2 participants