Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[expo-camera][IOS] Mute is not working when switching from picture to video #28739

Closed
lodev09 opened this issue May 10, 2024 · 1 comment · Fixed by #28783
Closed

[expo-camera][IOS] Mute is not working when switching from picture to video #28739

lodev09 opened this issue May 10, 2024 · 1 comment · Fixed by #28783
Assignees
Labels
needs review Issue is ready to be reviewed by a maintainer

Comments

@lodev09
Copy link

lodev09 commented May 10, 2024

Minimal reproducible example

https://github.com/lodev09/expo-camera-issue

What platform(s) does this occur on?

IOS

Did you reproduce this issue in a development build?

Yes

Summary

My app use case is the ability to "switch" from photo to video by long pressing the capture button. When switching from picture to video mode, the video output is always muted.

Related to this: #27984

Possible solution is to explicitly set muted={!isRecording}. However, the "dead frame" is clearly visible when doing so which is now a performance issue.

Note: no issue when mode is always set to video.

Environment

  expo-env-info 1.2.0 environment info:
    System:
      OS: macOS 14.4.1
      Shell: 5.9 - /bin/zsh
    Binaries:
      Node: 18.19.1 - /opt/homebrew/bin/node
      Yarn: 1.22.22 - /opt/homebrew/bin/yarn
      npm: 10.2.4 - /opt/homebrew/bin/npm
      Watchman: 2024.03.25.00 - /opt/homebrew/bin/watchman
    Managers:
      CocoaPods: 1.15.2 - /opt/homebrew/bin/pod
    SDKs:
      iOS SDK:
        Platforms: DriverKit 23.4, iOS 17.4, macOS 14.4, tvOS 17.4, visionOS 1.1, watchOS 10.4
    IDEs:
      Android Studio: 2023.2 AI-232.10300.40.2321.11668458
      Xcode: 15.3/15E204a - /usr/bin/xcodebuild
    npmPackages:
      expo: ^51.0.2 => 51.0.2 
      react: 18.2.0 => 18.2.0 
      react-native: 0.74.1 => 0.74.1 
    npmGlobalPackages:
      eas-cli: 8.0.0
    Expo Workflow: bare

Expo Doctor Diagnostics

✔ Check Expo config for common issues
✔ Check package.json for common issues
✔ Check dependencies for packages that should not be installed directly
✔ Check for issues with metro config
✔ Check for common project setup issues
✔ Check npm/ yarn versions
✔ Check native tooling versions
✔ Check Expo config (app.json/ app.config.js) schema
✔ Check that packages match versions required by installed Expo SDK
✔ Check for legacy global CLI installed locally
✔ Check that native modules do not use incompatible support packages
✔ Check that native modules use compatible support package versions for installed Expo SDK

Didn't find any issues with the project!
@lodev09 lodev09 added the needs validation Issue needs to be validated label May 10, 2024
@expo-bot expo-bot added needs review Issue is ready to be reviewed by a maintainer and removed needs validation Issue needs to be validated labels May 10, 2024
@lodev09
Copy link
Author

lodev09 commented May 10, 2024

I opened a PR to fix this behavior. Feel free to edit if I miss something. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review Issue is ready to be reviewed by a maintainer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants