Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expo Speech - onDone event doesn't fire anymore in Expo 51 on Web (expo-speech 12.0.2) #28762

Open
alyxb opened this issue May 10, 2024 · 0 comments
Assignees
Labels
needs review Issue is ready to be reviewed by a maintainer

Comments

@alyxb
Copy link

alyxb commented May 10, 2024

Minimal reproducible example

https://github.com/alyxb/expo-speech-bug

What platform(s) does this occur on?

Web

Did you reproduce this issue in a development build?

No (tested in Expo Go)

Summary

On web, the onDone event does not fire in expo-speech 12.0.2, but fires correctly in 11.7.0. Tested in Chrome Version 124.0.6367.156 (Official Build) (arm64):

   import * as Speech from "expo-speech";

   //...//

   const thingToSay = "This is a test of the onDone event.";

   const options = {
      onDone: () => {
        console.log("End of speech");
      },
   };

   Speech.speak(thingToSay, options);

In 11.7.0 the onDone event fires the function above, but not in 12.0.2.

Environment

expo-env-info 1.2.0 environment info:
System:
OS: macOS 13.6
Shell: 5.9 - /bin/zsh
Binaries:
Node: 21.5.0 - /opt/homebrew/bin/node
Yarn: 1.22.21 - /opt/homebrew/bin/yarn
npm: 10.2.4 - /opt/homebrew/bin/npm
Managers:
CocoaPods: 1.14.3 - /opt/homebrew/bin/pod
SDKs:
iOS SDK:
Platforms: DriverKit 22.4, iOS 16.4, macOS 13.3, tvOS 16.4, watchOS 9.4
IDEs:
Xcode: 14.3.1/14E300c - /usr/bin/xcodebuild
npmPackages:
expo: ~51.0.2 => 51.0.2
expo-router: ~3.5.11 => 3.5.11
react: 18.2.0 => 18.2.0
react-dom: 18.2.0 => 18.2.0
react-native: 0.74.1 => 0.74.1
react-native-web: ~0.19.10 => 0.19.11
Expo Workflow: managed

Expo Doctor Diagnostics

✔ Check Expo config for common issues
✔ Check package.json for common issues
✔ Check native tooling versions
✔ Check dependencies for packages that should not be installed directly
✔ Check for common project setup issues
✔ Check for issues with metro config
✔ Check npm/ yarn versions
✔ Check Expo config (app.json/ app.config.js) schema
✔ Check for legacy global CLI installed locally
✔ Check that native modules do not use incompatible support packages
✔ Check that packages match versions required by installed Expo SDK
✔ Check that native modules use compatible support package versions for installed Expo SDK

Didn't find any issues with the project!

@alyxb alyxb added the needs validation Issue needs to be validated label May 10, 2024
@expo-bot expo-bot added needs review Issue is ready to be reviewed by a maintainer and removed needs validation Issue needs to be validated labels May 10, 2024
@alyxb alyxb changed the title Expo Speech - onDone event doesn't fire anymore in Expo 51 (expo-speech 12.0.2) Expo Speech - onDone event doesn't fire anymore in Expo 51 on Web (expo-speech 12.0.2) May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review Issue is ready to be reviewed by a maintainer
Projects
None yet
Development

No branches or pull requests

3 participants