Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with Dark Mode: Poor Visibility of Selected Input #1509

Open
itsaalexk opened this issue May 2, 2024 · 6 comments
Open

Issue with Dark Mode: Poor Visibility of Selected Input #1509

itsaalexk opened this issue May 2, 2024 · 6 comments

Comments

@itsaalexk
Copy link

itsaalexk commented May 2, 2024

In the dark mode of the application, the design of the input when it is selected is not suitable and appears difficult to distinguish. This negatively impacts the user experience and may hinder interaction with the application.

Steps to Reproduce:

1.Switch to dark mode in the application settings.
2.Select an input in any part of the application where text input is required.
3.Note that the selected input does not stand out clearly against the dark background.

Expected Behavior:
The selected input should have a style or color that makes it clearly visible and distinguishable from the dark background, ensuring a smooth and confusion-free user experience.

Screenshot.

bug

Can I open a PR to fix this bug?

@itsaalexk itsaalexk added the bug label May 2, 2024
@crandmck
Copy link
Member

crandmck commented May 2, 2024

@chrisdel101

@chrisdel101
Copy link
Contributor

chrisdel101 commented May 2, 2024

Thanks for the feedback. It's just using the default focus outline that light mode also uses, but I see it is kind of cut off and doesn't look great. It's also seems to be different for Mac and Windows. It's blue on mac and grey on windows. I use a mac, so...

I cross browser tested, but not cross OS.

I tried to use github as the benchmark, and github just uses the blue outline. So if you can fix it so it's not cut off on the right, and maybe try to make it blue like github does, and make this work for both mac and windows? But leave the light mode setting as is.

Does this sound okay @crandmck ?

@jonchurch
Copy link
Member

thanks for the report @itsaalexk, feel free to PR

@crandmck
Copy link
Member

crandmck commented May 3, 2024

Yes, I agree any fix shouldn't affect light mode. @chrisdel101

Interestingly, in dark mode I don't see the search input field cut off as shown in the screenshot. Chrome on Mac.
@itsaalexk you didn't note your browser/OS, presumably that affects the behavior.

@itsaalexk
Copy link
Author

Im proceeding with creating the PR to fix this bug,

@itsaalexk
Copy link
Author

@crandmck The OS that im using is windows 11 and it was tested on Chrome and Brave browser , on both the bug still appears.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants