Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lack of partials support for handlebars #162

Open
alexanderankin opened this issue Jun 15, 2017 · 3 comments
Open

lack of partials support for handlebars #162

alexanderankin opened this issue Jun 15, 2017 · 3 comments

Comments

@alexanderankin
Copy link

The way the --hbs options currently works doesnt support partials, i suspect that it might be possible to change that without the use of an additional package, but there was a package designed specifically with this in mind, so i figured id use that instead.

In #161 I jumped the gun on the discussion phase and already submitted a replacement of the handlebars package which DG also maintains, and coded up the rest of the suggestions he laid out there. My plan is to resubmit a PR next week taking into account any feedback i get here, and also see if i can figure out how to get DG's handlebars package to support partials the way the package i found does.

@spaceraccoon
Copy link

Was there any progress on this?

@alexanderankin
Copy link
Author

short answer no

The issue was that the only considered reliable packages are those in the purview of the expressjs github organization which @dougwilson also manages, and he raises valid concerns about the huge matrix of supported platforms and versioning that come inherently as adding a node package into the mix from outside.

I didn't feel comfortable rewriting or augmenting existing package at the time, but for now I'd suggest installing the branch with the external package, running it to see the output it contains, copy/pasting the output to a github gist, reinstalling the generator from npm and just copy and pasting from the gist.

@spaceraccoon
Copy link

spaceraccoon commented Nov 30, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants