Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

response.end() proxy does not accept callback parameter #477

Closed
cwmunn opened this issue Jul 7, 2017 · 2 comments · May be fixed by #751
Closed

response.end() proxy does not accept callback parameter #477

cwmunn opened this issue Jul 7, 2017 · 2 comments · May be fixed by #751

Comments

@cwmunn
Copy link

cwmunn commented Jul 7, 2017

Hi!

We are using express-session with another middleware that uses the callback parameter of response.end().

The proxy that is attached to response.end() to save the session data does not accept the third callback parameter which results in the callback never getting called by the real implementation of end.

Would it be possible to accept the callback param and pass through?

Cheers,
~Chris
@dougwilson
Copy link
Contributor

Hi @cwmunn fix + tests are welcome! I think this is the first ask in all these years, so seems like a little-used feature, so may not get around to implementing myself.

@dougwilson
Copy link
Contributor

Closing because no PR has materialized.

@theneva theneva mentioned this issue May 18, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Proxy res.end(callback) calls correctly theneva/session
2 participants
@dougwilson @cwmunn