Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Branch-delete: Ask to delete tracking branch #875

Open
extrawurst opened this issue Aug 23, 2021 · 5 comments · May be fixed by #935
Open

Branch-delete: Ask to delete tracking branch #875

extrawurst opened this issue Aug 23, 2021 · 5 comments · May be fixed by #935
Labels
enhancement New feature or request good first issue Good for newcomers nostale immune to stale-bot

Comments

@extrawurst
Copy link
Owner

If I delete a local branch and it has an upstream I want to be asked to delete that aswell when I delete the local branch. Same vice versa
@extrawurst extrawurst added enhancement New feature or request good first issue Good for newcomers labels Aug 23, 2021
@extrawurst extrawurst added this to the v0.18 milestone Aug 23, 2021
@extrawurst
Copy link
Owner Author

Hello 👋🏾 I would like to help with this

for sure!

@extrawurst extrawurst modified the milestones: v0.17.1, v0.18 Sep 5, 2021
@extrawurst extrawurst added the nostale immune to stale-bot label Sep 19, 2021
@alessandroasm
Copy link
Contributor

Hello! Is this task assigned to someone? If not, I would like to work on it :)

@jim4067
Copy link

jim4067 commented Oct 7, 2021

Sorry, sorry. @alessandroasm , I was supposed to work on this but kept putting it off for silly reasons. You should have it. Again very, very sorry @extrawurst

@alessandroasm
Copy link
Contributor

Thank you @jim4067! I'll start working on this asap.

alessandroasm added a commit to alessandroasm/gitui that referenced this issue Oct 10, 2021
@alessandroasm
Feature extrawurst#875: Delete referring branches
74b7eae 
After deleting a branch, check if there are any upstream / tracking branches and
ask if user wants to delete them as well.
alessandroasm added a commit to alessandroasm/gitui that referenced this issue Oct 10, 2021
@alessandroasm
Feature extrawurst#875: Delete referring branches
b26eddf 
After deleting a branch, check if there are any upstream / tracking branches and
ask if user wants to delete them as well.
@alessandroasm alessandroasm linked a pull request Oct 10, 2021 that will close this issue
Draft
4 tasks
@alessandroasm
Copy link
Contributor

alessandroasm commented Oct 10, 2021 •
edited

I've just opened a draft PR for this (#935). I would like to hear your suggestions about the way I implemented this feature as it required a bigger than expected change. I would like to highlight a few things here:

  • I had to split process_confirmed_action in two functions, as clippy was not happy with a more than 100-line function.
  • I've created a function to find all local branches that track a provided remote one; I'm not sure, but I think it is possible to have multiple local branches tracking a single remote one.
  • I would like some suggestions on how to implement the unit tests :)

If you need anything, just let me know.
Thanks in advance!

@extrawurst extrawurst modified the milestones: v0.18, v0.19 Oct 11, 2021
@extrawurst extrawurst modified the milestones: v0.19, v0.20 Dec 4, 2021
@extrawurst extrawurst modified the milestones: v0.20, v0.21 Jan 22, 2022
@extrawurst extrawurst modified the milestones: v0.21, v0.22 Aug 17, 2022
@extrawurst extrawurst modified the milestones: v0.22, v0.23 Oct 20, 2022
@extrawurst extrawurst modified the milestones: v0.23, v0.24 Jun 19, 2023
@extrawurst extrawurst modified the milestones: v0.24, v0.25 Aug 21, 2023
@extrawurst extrawurst removed this from the v0.25 milestone Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers nostale immune to stale-bot
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature #875: Delete referring branches alessandroasm/gitui
3 participants
@extrawurst @alessandroasm @jim4067