Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decouple input from re-draw #869

Closed
extrawurst opened this issue Aug 22, 2021 · 3 comments · May be fixed by #948
Closed

decouple input from re-draw #869

extrawurst opened this issue Aug 22, 2021 · 3 comments · May be fixed by #948
Labels
enhancement New feature or request

Comments

@extrawurst
Copy link
Owner

  • drawing is significantly slower than input
  • this is most notable in complex widgets like the (rev)log
  • we should PoC if it is improving the experience if we decouple both
  • this would mean instead of every input triggering a redraw, we buffer up inputs that happen during a ongoing redraw
@extrawurst extrawurst added the enhancement New feature or request label Aug 22, 2021
@R0nd
Copy link
Contributor

R0nd commented Oct 14, 2021

What would be a good performance metric for this optimization? I've thrown together some update buffering, but scrolling through revlog is still significantly slowed down by the git log fetch. Could probably use some mechanism for async operation cancellation.

@extrawurst
Copy link
Owner Author

Last time I benchmarked the drawing was slower than the rate of input events so the idea was to allow two(or more) event processings before redrawing again. This would significantly change the architecture though so it should be carefully measured whether this has enough upsides to carry itself

@R0nd R0nd mentioned this issue Oct 16, 2021
4 tasks
@stale

This comment was marked as outdated.

@stale stale bot added the dormant Marked by stale bot on close label Apr 16, 2022
@stale stale bot closed this as completed May 1, 2022
@extrawurst extrawurst removed the dormant Marked by stale bot on close label Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants