feat: Validate ISO timestamps with offsets #496
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for creating this PR. Since I am currently busy rewriting the library based on #463, it may take some time before I release the next version. So I don't recommend to wait and use the |
|
Sure, no problem! 😄 |
Closed
brandonpittman
approved these changes
Apr 2, 2024
|
Would you like me to port this changes as part of #502? This would technically be a breaking change, as inputs that would previously throw an error may now pass, so bundling it with other breaking changes might be appropriate. |
|
Feel free to contribute to #502, but don't go crazy, because I don't want to spend too much time on new features. I want to get the next version out as soon as possible. Until v1, breaking changes are ok. |
|
Thank you! Merged in #530. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a bunch of tests with both valid and invalid timestamps and updated the JSDoc to list all the allowed formats.
The regex is relatively permissive as it allows for any number in the offset. If something stricter is required, I can work on it, but I'm afraid it would explode in complexity. For example, a
00:00offset is valid only if preceded by a+and not by-; the maximum offset should be ±12:00, etc.Closes #495.