{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":23821422,"defaultBranch":"main","name":"fatal","ownerLogin":"facebook","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2014-09-09T06:04:59.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/69631?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1716822174.0","currentOid":""},"activityList":{"items":[{"before":"2602114b4814b5cc6693456521cc880e8c427461","after":"31d2aa4e8199492308d2e25429abea3c1483ccd7","ref":"refs/heads/main","pushedAt":"2024-05-06T08:19:38.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Change `result_of` to `invoke_result` in fatal/container/legacy_variant.h\n\nSummary: C++20 has [eliminated](https://en.cppreference.com/w/cpp/types/result_of) `result_of` in favour of `invoke_result`. It's mysterious that this code even still works, but, nevertheless, I'm fixing it.\n\nDifferential Revision: D56987396\n\nfbshipit-source-id: 71ca954c5825fb8f0e1939e51c77fe700b1dff20","shortMessageHtmlLink":"Change <code>result_of</code> to <code>invoke_result</code> in fatal/container/legacy_varia…"}},{"before":"4fe76ddd0875bd746bdd42fb9112ee0f7f0e757d","after":"2602114b4814b5cc6693456521cc880e8c427461","ref":"refs/heads/main","pushedAt":"2024-02-26T20:56:39.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"let the driver in fatal/lesson/ be a source file\n\nReviewed By: Orvid, dmm-fb\n\nDifferential Revision: D54123652\n\nfbshipit-source-id: 768e18abf550eed02fa6f97fb83e2b75d30060c7","shortMessageHtmlLink":"let the driver in fatal/lesson/ be a source file"}},{"before":"fa438c98f87e9693f7721bb3196db9edc537acf2","after":"4fe76ddd0875bd746bdd42fb9112ee0f7f0e757d","ref":"refs/heads/main","pushedAt":"2024-02-26T16:23:46.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix deprecated use of 0/NULL in fatal/test/type.h + 3\n\nSummary:\n`nullptr` is typesafe. `0` and `NULL` are not. In the future, only `nullptr` will be allowed.\n\nThis diff helps us embrace the future _now_ in service of enabling `-Wzero-as-null-pointer-constant`.\n\nReviewed By: meyering\n\nDifferential Revision: D54163064\n\nfbshipit-source-id: 1b597d8f4893bdb9961326c4c2e6e9c9ada78aad","shortMessageHtmlLink":"Fix deprecated use of 0/NULL in fatal/test/type.h + 3"}},{"before":"0874680f7c1929b14525210b4246ba3a3d05614c","after":"fa438c98f87e9693f7721bb3196db9edc537acf2","ref":"refs/heads/main","pushedAt":"2024-02-23T20:25:20.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"fatal/container\n\nReviewed By: yfeldblum\n\nDifferential Revision: D54107243\n\nfbshipit-source-id: 0129f08e2fd528891efbaf900258dfb9a9f3700c","shortMessageHtmlLink":"fatal/container"}},{"before":"425d5c0683de44bb9bf175699472510a69a18faa","after":"0874680f7c1929b14525210b4246ba3a3d05614c","ref":"refs/heads/main","pushedAt":"2024-01-25T01:05:38.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove extra semi colon from fatal/string/rope.h\n\nSummary:\n`-Wextra-semi` or `-Wextra-semi-stmt`\n\nIf the code compiles, this is safe to land.\n\nReviewed By: dmm-fb\n\nDifferential Revision: D52965935\n\nfbshipit-source-id: ff098f6836e0175b4f8be41874890147e8195d24","shortMessageHtmlLink":"Remove extra semi colon from fatal/string/rope.h"}},{"before":"95eba95bda80e58bef54705d925c13dcd80180e8","after":"425d5c0683de44bb9bf175699472510a69a18faa","ref":"refs/heads/main","pushedAt":"2024-01-24T21:09:26.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove extra semi colon from fatal/type/test/foreach_test.cpp\n\nSummary:\n`-Wextra-semi` or `-Wextra-semi-stmt`\n\nIf the code compiles, this is safe to land.\n\nReviewed By: vitaut\n\nDifferential Revision: D52965958\n\nfbshipit-source-id: db27074ccc119f76cd541aabe0fc17a0258c79c1","shortMessageHtmlLink":"Remove extra semi colon from fatal/type/test/foreach_test.cpp"}},{"before":"3cda2f95571b537596531494080b2ef6de14f09d","after":"95eba95bda80e58bef54705d925c13dcd80180e8","ref":"refs/heads/main","pushedAt":"2024-01-22T17:24:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"ci: Use GITHUB_OUTPUT envvar instead of set-output command\n\nSummary:\n`save-state` and `set-output` commands used in GitHub Actions are deprecated and [GitHub recommends using environment files](https://github.blog/changelog/2023-07-24-github-actions-update-on-save-state-and-set-output-commands/).\n\nThis PR updates the usage of `set-output` to `$GITHUB_OUTPUT`\n\nInstructions for envvar usage from GitHub docs:\n\nhttps://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-an-output-parameter\n\nX-link: https://github.com/facebook/proxygen/pull/480\n\nReviewed By: bigfootjon\n\nDifferential Revision: D52918113\n\nPulled By: jbeshay\n\nfbshipit-source-id: bfc05a7e25f8401c1c6501f2c467fb4ead091102","shortMessageHtmlLink":"ci: Use GITHUB_OUTPUT envvar instead of set-output command"}},{"before":"af9432600985ddbcf6131e1e4d9ce95dead1586e","after":"3cda2f95571b537596531494080b2ef6de14f09d","ref":"refs/heads/main","pushedAt":"2024-01-19T02:07:29.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"fix shadowed variable in fatal/type/deprecated/type_map.h\n\nReviewed By: Orvid\n\nDifferential Revision: D52582921\n\nfbshipit-source-id: 50707099ee28f8db54453a9dc29608b7f2501a85","shortMessageHtmlLink":"fix shadowed variable in fatal/type/deprecated/type_map.h"}},{"before":"4f4c8cfd701223ac1c11d1a3c569f9087d4d326d","after":"af9432600985ddbcf6131e1e4d9ce95dead1586e","ref":"refs/heads/main","pushedAt":"2023-11-30T01:21:26.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove extraneous semicolon from fatal/type/impl/trie.h\n\nSummary:\nExtraneous semicolons are a code smell and can mask more serious problems. `-Wextra-semi-stmt` finds them.\n\nThis diff removes an extraneous semicolon or adjusts a macro so that a semicolon is required after the macro (making it look like a standard function).\n\nThis file is drawn from a heavy-hitting list, so fixing this problem will allow *many* other files to take advantage of the safety `-Wextra-semi-stmt` offers.\n\nThis should be a low-risk diff: if it compiles, it works.\n\nReviewed By: meyering\n\nDifferential Revision: D51631110\n\nfbshipit-source-id: b639984664d990dbf97d1f366f54449ed98ae9ca","shortMessageHtmlLink":"Remove extraneous semicolon from fatal/type/impl/trie.h"}},{"before":"b81bb23e1b220147d27aa147272e0a69a3f6ec4a","after":"4f4c8cfd701223ac1c11d1a3c569f9087d4d326d","ref":"refs/heads/main","pushedAt":"2023-09-29T04:45:07.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"fatal, fatema, fava, fb303 (-1448123696577713427)\n\nReviewed By: cvanwinkle\n\nDifferential Revision: D49722306\n\nfbshipit-source-id: ec87f3555b317b1c3f527b6386aa3f385eda5b5f","shortMessageHtmlLink":"fatal, fatema, fava, fb303 (-1448123696577713427)"}},{"before":"bb10c39e8e470e3de0219ab1aab3629fb31bef5f","after":null,"ref":"refs/heads/fix-builds-with-gcc","pushedAt":"2023-08-24T03:00:51.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"yfeldblum","name":"Jay Feldblum","path":"/yfeldblum","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/169419?s=80&v=4"}},{"before":"534770812681c614e5971b3a6998ca355300b82a","after":"b81bb23e1b220147d27aa147272e0a69a3f6ec4a","ref":"refs/heads/main","pushedAt":"2023-08-23T20:09:29.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"fix various build failures under recent gcc (#136)\n\nSummary: Pull Request resolved: https://github.com/facebook/fatal/pull/136\n\nReviewed By: Orvid\n\nDifferential Revision: D48616420\n\nPulled By: yfeldblum\n\nfbshipit-source-id: 4aafda015f62e34e69ea5933c36a17cf8c03b0b3","shortMessageHtmlLink":"fix various build failures under recent gcc (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1863895838\" data-permission-text=\"Title is private\" data-url=\"https://github.com/facebook/fatal/issues/136\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/facebook/fatal/pull/136/hovercard\" href=\"https://github.com/facebook/fatal/pull/136\">#136</a>)"}},{"before":null,"after":"bb10c39e8e470e3de0219ab1aab3629fb31bef5f","ref":"refs/heads/fix-builds-with-gcc","pushedAt":"2023-08-23T19:27:38.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"yfeldblum","name":"Jay Feldblum","path":"/yfeldblum","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/169419?s=80&v=4"},"commit":{"message":"fix various build failures under recent gcc","shortMessageHtmlLink":"fix various build failures under recent gcc"}},{"before":"011598953c5448fa4763a1e77320576f0853b5c2","after":"534770812681c614e5971b3a6998ca355300b82a","ref":"refs/heads/main","pushedAt":"2023-08-20T18:43:11.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"remove out-of-line definitions of constexpr static data members\n\nSummary: They are deprecated and clang emits warnings when they occur, starting with llvm-v15.\n\nReviewed By: NSProgrammer\n\nDifferential Revision: D48501736\n\nfbshipit-source-id: 588afcec7072b31f842672fd280aa4b994e096bb","shortMessageHtmlLink":"remove out-of-line definitions of constexpr static data members"}},{"before":"6a901dde7bfdddf774ba3c88648bc91a89026550","after":"011598953c5448fa4763a1e77320576f0853b5c2","ref":"refs/heads/main","pushedAt":"2023-07-18T01:12:21.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Unbreak tuple::push_{front,back}\n\nSummary: They were untested and didn't work, at least not as I thought they were intended to be used. Now they seem to work?\n\nReviewed By: eduardo-elizondo\n\nDifferential Revision: D47231442\n\nfbshipit-source-id: d20663c3e1d9b363553351b6b77a1db2d6ea1adc","shortMessageHtmlLink":"Unbreak tuple::push_{front,back}"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEQk2biwA","startCursor":null,"endCursor":null}},"title":"Activity · facebook/fatal"}