Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alignItems & baseline is not working properly with Text alignment #789

Open
1 task done
ryanhoo opened this issue May 1, 2021 · 1 comment
Open
1 task done

Comments

@ryanhoo
Copy link

ryanhoo commented May 1, 2021

Version

The latest code on master branch.

Issues and Steps to Reproduce

Paste the code below to PlaygroundComponentSpec and run Litho sample project, click on Playground button and you will see this:
2

Expected Behavior

1

Link to Code

@LayoutSpec
public class PlaygroundComponentSpec {

    @OnCreateLayout
    static Component onCreateLayout(ComponentContext c) {
        return Row.create(c)
                .paddingDip(YogaEdge.ALL, 24f)
                .alignItems(YogaAlign.BASELINE)
                .child(Text.create(c).text("$").textSizeDip(13f).backgroundColor(0x10000000))
                .child(Text.create(c).text("16").textSizeDip(33f).lineHeightDip(33f).backgroundColor(0x20000000))
                .child(Text.create(c).text(".87").textSizeDip(13f).backgroundColor(0x10000000))
                .build();
    }
}
@ryanhoo ryanhoo changed the title alignItems & baseline is not working properly with Text alignment alignItems: baseline is not working properly with Text alignment May 10, 2021
@ryanhoo ryanhoo changed the title alignItems: baseline is not working properly with Text alignment alignItems & baseline is not working properly with Text alignment May 10, 2021
@noobyogi0010
Copy link

Hi, @ryanhoo
I would like to work on this issue, if no one else have taken it up already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants