Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit re-opening WAL for truncating to current size #12471

Open
pdillinger opened this issue Mar 22, 2024 · 0 comments
Open

Limit re-opening WAL for truncating to current size #12471

pdillinger opened this issue Mar 22, 2024 · 0 comments

Comments

@pdillinger
Copy link
Contributor

Currently, we have code that calls ReopenWritableFile on the latest WAL file on recovery:

https://github.com/facebook/rocksdb/blob/9.0.fb/db/db_impl/db_impl_open.cc#L1555-L1566

with the purpose of freeing any fallocated space that might be leftover. This is unnecessary on filesystems that don't support fallocate, or maybe don't even support re-opening a file for write after it has been closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant