Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More varied product descriptions #2871

Open
matthewmayer opened this issue May 3, 2024 · 2 comments
Open

More varied product descriptions #2871

matthewmayer opened this issue May 3, 2024 · 2 comments
Labels
c: feature Request for new feature m: commerce Something is referring to the commerce module p: 1-normal Nothing urgent s: waiting for user interest Waiting for more users interested in this feature

Comments

@matthewmayer
Copy link
Contributor

Clear and concise description of the problem

There are only 12 possible product descriptions in faker.commerce.productDescription() in en

Suggested solution

Similar to how we handled faker.food.description(), switch to using fake() over arrayElement() and sprinkle some additional placeholders like {{color.human}}, {{word.adjective}} in the descriptions for additional variety.

This would be backwards compatible with existing definitions in other locales, since fake patterns can just be static strings.

Alternative

No response

Additional context

No response

@matthewmayer matthewmayer added c: feature Request for new feature s: pending triage Pending Triage s: waiting for user interest Waiting for more users interested in this feature labels May 3, 2024
Copy link

github-actions bot commented May 3, 2024

Thank you for your feature proposal.

We marked it as "waiting for user interest" for now to gather some feedback from our community:

  • If you would like to see this feature be implemented, please react to the description with an up-vote (:+1:).
  • If you have a suggestion or want to point out some special cases that need to be considered, please leave a comment, so we are aware about them.

We would also like to hear about other community members' use cases for the feature to give us a better understanding of their potential implicit or explicit requirements.

We will start the implementation based on:

  • the number of votes (:+1:) and comments
  • the relevance for the ecosystem
  • availability of alternatives and workarounds
  • and the complexity of the requested feature

We do this because:

  • There are plenty of languages/countries out there and we would like to ensure that every method can cover all or almost all of them.
  • Every feature we add to faker has "costs" associated to it:
    • initial costs: design, implementation, reviews, documentation
    • running costs: awareness of the feature itself, more complex module structure, increased bundle size, more work during refactors

View more issues which are waiting for user interest

@matthewmayer matthewmayer added the m: commerce Something is referring to the commerce module label May 3, 2024
@ST-DDT
Copy link
Member

ST-DDT commented May 3, 2024

@matthewmayer Please don't forget to upvote your own feature requests.

@ST-DDT ST-DDT added the p: 1-normal Nothing urgent label May 3, 2024
@xDivisionByZerox xDivisionByZerox removed the s: pending triage Pending Triage label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: feature Request for new feature m: commerce Something is referring to the commerce module p: 1-normal Nothing urgent s: waiting for user interest Waiting for more users interested in this feature
Projects
None yet
Development

No branches or pull requests

3 participants