-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should we drop Node.js v18 for v5? #5460
Comments
+1 Additional information on usage: https://nodedownloads.nodeland.dev/ |
Let's do it. |
Independent from fastify, my use cases at work only use node 20. |
I don't know folks, there doesn't seem to be a right or wrong.
I don't have full visibility around any of the points above: I don't know when v5 is due to be released, I don't know how much effort it is to support v18, and I don't know which cloud providers support which Node.js version, but they're the things I would consider when making a decision. |
Node.js v18 is not Active LTS. It's maintenance LTS and will be out of support in April 2025.
There are many differences between Node.js v18 and v20, and I expect this to grow. My main concern is the flakyness of Node.js v18 in CI. We could wait and make a last-minute decision based on the fact that the FinalizationRegistry bug is backported and released on v18. (this causes flakyness both to Pino and Undici). |
You're right about Node 18 being maintenance, my bad. Although the other two considerations still hold, 18 being maintenance is a fairly compelling reason to drop it, I agree. |
Also, we will be committed to supporting v4 for quite some time. It will cover those on the old releases. |
I do not oppose to support less version at the beginning of new major. |
Node 18 is now dropped from all CIs that correspond to the next release |
Given that the gap between v18 and v20 is growing quickly, I think we could just drop v18 in v5.
This will save us so many flaky CI runs in the future, given the problems v18 has with FinalizationRegistry (I still hope a fix will be backported at some point).
The text was updated successfully, but these errors were encountered: