Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sometimes the updater sends the message "OK" when failing #648

Open
JvdMaat opened this issue Nov 22, 2023 · 4 comments
Open

Sometimes the updater sends the message "OK" when failing #648

JvdMaat opened this issue Nov 22, 2023 · 4 comments
Labels
bug Something isn't working as expected logging Related to what the tool outputs to the end user
Milestone
1.12.0

Comments

@JvdMaat
Copy link
Contributor

JvdMaat commented Nov 22, 2023 •
edited

Following up on #615, I just had the following error in the docker logs:

🔔 Successfully pinged Uptime Kuma
⏰ Checking the IP addresses in about 5m0s . . .
😞 Failed to send HTTP(S) request to "https://1.1.1.1/cdn-cgi/trace": context deadline exceeded
😞 Failed to detect the IPv4 address
🔔 Successfully pinged Uptime Kuma
⏰ Checking the IP addresses in about 4m55s . . .
🌐 Detected the IPv4 address: 71.x.y.86
🤷 The A records of "ddns.domain.com" are already up to date
🔔 Successfully pinged Uptime Kuma
⏰ Checking the IP addresses in about 5m0s . . .

Which is totally fine (I rebooted my router, so the container was running, but it couldn't reach the internet for that one interval).
However this is what Uptime Kuma showed:
image
(So it sent an OK instead of the actual issue of "context deadline exceeded" (or request timed out, or whatever makes sense as error message))
@favonia
Copy link
Owner

favonia commented Nov 22, 2023 •
edited

@JvdMaat Sorry that we didn't completely fix the problem. May I confirm that you are using 1.11.0?

@JvdMaat
Copy link
Contributor Author

JvdMaat commented Nov 22, 2023

Yes I'm running 1.11.0. And the problem is mostly fixed. It works for other errors. Just this one doesn't have an appropriate Message string when reporting a down condition.

@favonia favonia added the bug Something isn't working as expected label Nov 27, 2023
@favonia favonia changed the title Feature request: Monitoring fix Sometimse the updator sends "OK" when it's failing. Nov 27, 2023
@favonia favonia changed the title Sometimse the updator sends "OK" when it's failing. Sometimse the updator sends the message "OK" for failing messages Nov 27, 2023
@favonia favonia changed the title Sometimse the updator sends the message "OK" for failing messages Sometimse the updator sends the message "OK" when failing Nov 27, 2023
@favonia
Copy link
Owner

favonia commented Nov 28, 2023

@JvdMaat Hi, I wonder how annoying this bug is to you? I'm in the middle of (extremely slowly) adding shoutrrr (see #632) and I prefer not to release a version with lots of non-functional code. However, the non-working code does not affect other functionalities and nothing prevents me from releasing a bugfix, either.

@JvdMaat
Copy link
Contributor Author

JvdMaat commented Nov 28, 2023

This bug has little to no impact on me. Just a cleanup of missing error messages as far as I'm concerned. File it with nice to have.

@JvdMaat JvdMaat changed the title Sometimse the updator sends the message "OK" when failing Sometimes the updater sends the message "OK" when failing Nov 30, 2023
@favonia favonia pinned this issue Feb 21, 2024
@favonia favonia unpinned this issue Feb 21, 2024
@favonia favonia added the logging Related to what the tool outputs to the end user label Mar 3, 2024
@favonia favonia added this to the 1.12.0 milestone Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working as expected logging Related to what the tool outputs to the end user
Projects
None yet
Milestone
1.12.0
Development

No branches or pull requests
2 participants
@favonia @JvdMaat