Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Amiguity of Helm chart value names and lack of documentation on them #1352

Open
realkarmakun opened this issue Feb 23, 2024 · 0 comments

Comments

@realkarmakun
Copy link

Description

As of now documentation just says to install Cert manager and specifies a helm value called nginx.
What is this nginx value entails? Is it separate ingress instance that would featureform's chart install? Or some internal mechanism for making ingress working?

What if I already have nginx ingress in a cluster? In that case wouldn't it make sense to use not global. values but ingress. ones? What is embeddableIngress value? There is also disabled: true enabled: false values which is very confusing (referring to default values on artifact hub: https://artifacthub.io/packages/helm/featureform/featureform)

Current Behavior

No response

Desired Behavior

More consistent values setup, and a bit more deep documentation on values, possibly with examples.
All ingress setup should be happening separately in ingress node and there should not be happening any confusing ingress and nginx related values in the global part. User have to setup ingress as they like, choose tls secret there in there, choose domain, type of resolution and specify annotations.

If the installation of nginx-ingress should stay in chart is should be specifed under some installNginx value or soemhting not just plain nginx, that's just confusing.

It would be nice to have description of those to be more precise e.g.:
global.tlsSecretName | Will set the name of the TLS secret for the ingress to use if manually adding a certificate What if I already have a secret? What if I want to let Cert Manager to to automatically make a certificate for me?

All and all I would like the chart to be more friendly to installing on already running setups, it would be nice to have instructions for both automatic nginx setup as well as directions for setting up featureform with already existing nginx-ingress and perhaps others ingresses (like traefik)

Benefits

Overall it's a good practice. Would allow to setup scaled featureform instances more easily

Possible Implementation

No response

Additional Context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant