Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit schema_digest Field name in Envelope #365

Closed
Archento opened this issue May 10, 2024 · 1 comment · Fixed by #363
Closed

Revisit schema_digest Field name in Envelope #365

Archento opened this issue May 10, 2024 · 1 comment · Fixed by #363

Comments

@Archento
Copy link
Member

This field schema_digest was initially called protocol unfortunately, and this alias was created to preserve backwards compatibility.
It seems that we don't need the Field alias anymore so I propose to remove it. Currently this also leads to introspection errors as the Envelope class still 'expects' the protocol field to be populated.
@Archento Archento mentioned this issue May 10, 2024
Merged
@Archento
Copy link
Member Author

Covered in #363

@Archento Archento linked a pull request May 16, 2024 that will close this issue
refactor(core): context stage 2 #363
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(core): context stage 2 fetchai/uAgents
1 participant
@Archento