Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify more recent awscli dependency to avoid dependency resolution issues #239

Closed
3 tasks done
phoerious opened this issue Feb 24, 2023 · 8 comments
Closed
3 tasks done

Comments

@phoerious
Copy link

phoerious commented Feb 24, 2023

Mandatory

  • I read the documentation (readme and wiki).
  • I searched other issues (including closed issues) and could not find any to be related. If you find related issues post them below or directly add your issue to the most related one.
  • I confirm that this bug report does not report on a specific news site where news-please does not work. Please keep in mind that news-please is a generic crawler so it is expected that it will not work for all sites well or even at all.

Related issues:

Describe the bug
news-please depends on awscli>=1.11.117, but versions this old have broken metadata on PyPi. Using a package manager that tries to resolve dependencies (such as Poetry) will therefore have to download and inspect every single awscli version that has been published since about 2017. My last poetry lock took 3.5 hours. This issue can be fixed by simply depending on a more recent version (no earlier than October 2021, see aws/aws-cli#5701).

I would suggest to simply depend on the most recent at the time, i.e., awscli>=1.27.78.

@fhamborg
Copy link
Owner

Does this have any side effects, e.g., the more recent awscli version having dependency conflicts with NP?

@phoerious
Copy link
Author

Not I know of.

@fhamborg
Copy link
Owner

fhamborg commented Jun 4, 2024

Could you pinpoint me to where the awscli requirements comes from? I dont see it in the project files.

@phoerious
Copy link
Author

Looks like this was removed a while ago. 14d0a20

@fhamborg
Copy link
Owner

fhamborg commented Jun 4, 2024

alright, thanks for the info

@fhamborg fhamborg closed this as completed Jun 4, 2024
@fhamborg fhamborg reopened this Jun 4, 2024
@fhamborg
Copy link
Owner

fhamborg commented Jun 4, 2024

though, im wondering, why you ran into this issue. you opened the bug report in 2023 whereas the awscli was already removed in 2022. is this somehow still an issue or you just used an older version?

@phoerious
Copy link
Author

phoerious commented Jun 4, 2024

Yeah, I believe that's the problem. Although that commit is older than my issue report, the latest version available on PyPi at the time was 1.5.22, which is from 4 April 2022 (18 days before that commit). The first version to include the fix must be 1.5.33, which is from 17 April 2023, about a year later.

@fhamborg
Copy link
Owner

fhamborg commented Jun 4, 2024

Alright, thanks for the clarification!!

@fhamborg fhamborg closed this as completed Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants