Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request] support for resetting virtio devices #3074

Open
3 tasks done
cperciva opened this issue Jul 31, 2022 · 5 comments · May be fixed by #4389
Open
3 tasks done

[Feature Request] support for resetting virtio devices #3074

cperciva opened this issue Jul 31, 2022 · 5 comments · May be fixed by #4389
Labels
Priority: Low Indicates that an issue or pull request should be resolved behind issues or pull requests labelled `

Comments

@cperciva
Copy link
Contributor

Feature Request

During the FreeBSD boot process, it resets network devices. (Why? Good question.) When running in Firecrackers, this means resetting the vtnet device.

Describe the desired solution

When a status of 0 is written to the virtio device, it should reset.

It looks like the MMIO code in Firecracker gets this right, but it calls a _reset routine for the device and none of the devices have implemented it. As a result, the device is currently entering FAILED state instead.

Describe possible alternatives

FreeBSD's virtio driver doesn't actually notice that the device is in FAILED state, and Firecracker's devices continue to work despite being marked as FAILED -- so everything ends up working except for Firecracker logging warnings of ack virtio features in invalid state 0x8f and update virtio queue in invalid state 0x8f. But this (arguably buggy) behaviour of ignoring that the device has failed could change in the future, so it would be good to avoid having it marked as failed in the first place.

Additional context

Checks

  • Have you searched the Firecracker Issues database for similar requests?
  • Have you read all the existing relevant Firecracker documentation?
  • Have you read and understood Firecracker's core tenets?
@alsrdn
Copy link
Contributor

alsrdn commented Aug 8, 2022

@cperciva can you share your kernel and rootfs so we can reproduce the issue?

@cperciva
Copy link
Contributor Author

cperciva commented Aug 8, 2022

@alsrdn Happy to share, but FreeBSD relies on PVH booting (see #3041) so it doesn't work on mainline Firecracker yet. Unless you want to work on virtio reset urgently I'd suggest waiting until I can get PVH support merged to Firecracker (which is next on my to-do list after I finish the outstanding issues on FreeBSD's side).

@alsrdn
Copy link
Contributor

alsrdn commented Aug 9, 2022

Ah yes, that makes sense. Better to wait then.

@mattschlebusch mattschlebusch added the Priority: Low Indicates that an issue or pull request should be resolved behind issues or pull requests labelled ` label May 9, 2023
@cperciva cperciva mentioned this issue Jul 25, 2023
Open
@pb8o
Copy link
Contributor

pb8o commented Sep 18, 2023

Waiting on #4073

@iMilnb
Copy link

iMilnb commented Jan 11, 2024

I can confirm the same behavior occurs also in NetBSD when bringing up the VirtIO NIC.

@acj acj linked a pull request Jan 22, 2024 that will close this issue
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: Low Indicates that an issue or pull request should be resolved behind issues or pull requests labelled `
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support reset for net device acj/firecracker
5 participants
@iMilnb @cperciva @mattschlebusch @alsrdn @pb8o