Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API exception if transaction is deleted by rule #8665

Open
4 tasks done
Medformatik opened this issue Mar 12, 2024 · 4 comments
Open
4 tasks done

API exception if transaction is deleted by rule #8665

Medformatik opened this issue Mar 12, 2024 · 4 comments
Labels
enhancement Requests for enhancements of existing stuff.

Comments

@Medformatik
Copy link

Medformatik commented Mar 12, 2024

Support guidelines

I've found a bug and checked that ...

Description

The issue has already been reported in #5177 but it hasn't been fixed. If there is a rule that deletes transactions created by the API or the data importer in certain cases (in my case, if it has the tag pending), an error is triggered (as described in the issue).

200032: Cannot find transaction. Possibly, a rule deleted this transaction after its creation.

This is understandable so far, but in this case the deletion is intended. Therefore, I don't want to receive an email with such an error every time.

Debug information

Debug information generated at 2024-03-12 08:32:57 for Firefly III version v6.1.10.

System information
ItemValue
Firefly III6.1.10 / v2.0.12 / 22 (exp. 22)
PHP version8.3.3 (64bits) / apache2handler / Linux x86_64
BCscale12
Error reportingDisplay: Off, reporting: ALL errors
Max upload67108864 (64 MB)
Database drivers*mysql*, pgsql, sqlite,
Docker build#1003, base #81
Firefly III information
ItemValue
TimezoneEurope/Berlin + Europe/Berlin
App environmentlocal, debug: false
Layoutv1
Loggingnotice, stack / (empty)
Cache driverfile
Default language and localede_DE + equal
Trusted proxies**
Login provider & user guardeloquent / web
Login headersN/A + N/A
Stateful domains
Last cron job2024-03-12 00:00:00 (8 hours ago)
Mailersmtp
User-specific information
ItemValue
User#1 of 1
User flags🔧
Session start
Session end
View range1M
User languagede_DE
User localede_DE
Locale(s) supportedde_DE.utf8: ✅
de_DE.UTF-8: ✅
User agentMozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:123.0) Gecko/20100101 Firefox/123.0

Expected behaviour

It would be great if you could set how this case is handled. I want the deletion so that the import only happens when the booking is no longer pending. Therefore, I don't care about the error and I don't need to receive any emails about it.

Steps to reproduce

  1. Create a rule which deletes a transaction on creation
  2. Create a transaction via API or data importer which is covered by this rule

Additional info

No response

@JC5
Copy link
Member

JC5 commented Mar 12, 2024

Sorry, since this could also be an indication of other problems I'm not planning to change this behavior.

@Medformatik
Copy link
Author

Medformatik commented Mar 12, 2024

Wouldn't it be an idea to be able to set that the error is ignored (not by default, of course) or at least that no email is sent for it?
Or an API parameter with which you can specify that such an error should be ignored (and then a corresponding option in the data importer).
Or is your recommendation simply to turn off the error emails completely? I have to deal with it somehow.

@JC5
Copy link
Member

JC5 commented Mar 12, 2024

I'll see what I can do.

@JC5 JC5 added the enhancement Requests for enhancements of existing stuff. label Mar 12, 2024
Copy link
Contributor

Hi there!

This is an automatic reply. Share and enjoy

This issue has been marked as an enhancement. The requested enhancement to an existing feature will become a part of Firefly III or the data importer in due course.

If you come across this issue, please be aware there is NO need to reply with "+1" or "me too" or "I need this too" or whatever. Such comments are not helpful, and do not influence the roadmap. Your comment may be 💀 deleted. You can subscribe to this issue to get updates.

Thank you for your contributions.

@JC5 JC5 added this to the importer-v4.0.0 milestone Mar 12, 2024
JC5 added a commit to firefly-iii/data-importer that referenced this issue Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Requests for enhancements of existing stuff.
Projects
Status: Done
Development

No branches or pull requests

2 participants