Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared-prefix rope issue #194

Open
lkc1997 opened this issue Apr 1, 2024 · 1 comment
Open

Shared-prefix rope issue #194

lkc1997 opened this issue Apr 1, 2024 · 1 comment

Comments

@lkc1997
Copy link

lkc1997 commented Apr 1, 2024

image
I found that during shared-prefix calculation, this kenerl won't use qo_indptr to split batch queries which may cause rope error.

@yzh119
Copy link
Collaborator

yzh119 commented May 7, 2024

Hi @lkc1997 , we have another few arguments (rope_position to specify the rope position of each query) in our C++ APIs but we have ported them into PyTorch APIs, I'll do that in next release.

You can process rope outside attention and use attention kernel without rope at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants