Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified Plan #8

Closed
igala opened this issue Oct 16, 2020 · 8 comments
Closed

Unified Plan #8

igala opened this issue Oct 16, 2020 · 8 comments

Comments

@igala
Copy link

igala commented Oct 16, 2020

Great project!!

Are you planning to support unified plan?

@shivanshtalwar0
Copy link
Collaborator

Definitely! Its on my todo list, once audioroom support and testing is done i will develop it

@igala
Copy link
Author

igala commented Oct 17, 2020

I am considering helping in implementing the unified plan support. Will it work for you? Can you give some guidelines?

@shivanshtalwar0
Copy link
Collaborator

Sure I would love to have a contribution from a lovely community!
Regarding guidelines for unified support
(1) First of all we need to verify what is the status of flutter_webrtc when it comes to unified plan because ultimately all webRTC stack depends on flutter_webrtc plugin
(2) We need to make a separate branch for unified/multistreaming support, as Janus gateway now supports multistreaming for quite a while now on the multistreaming branch
(3) we need to heavily rely on Janus multistreaming branch for implementation and examples for the same
once we have working examples for unified support on a unified branch we will then focus on integrating it with the current codebase that is master

do share your views on how you feel about this plan?

@shivanshtalwar0
Copy link
Collaborator

According to this unified plan is under development
unified plan webrtc

@shivanshtalwar0
Copy link
Collaborator

for the time being, you could help me complete the audio room and testing of this project.
Thanks for your interest!

@shivanshtalwar0 shivanshtalwar0 pinned this issue Oct 17, 2020
@igala
Copy link
Author

igala commented Oct 17, 2020

Hi,

  1. Unified plan is supported in flutter webrtc, you can check the main page of the repo, please look at the table:
    https://github.com/flutter-webrtc/flutter-webrtc

Also the unified plan branch was merged in the the master

  1. Yes I will work on a new branch for this change since Janus do not support both plans they transitioned to unified plan only.

  2. Yes I agree , it will be relied on the Janus JS client . Your code is not organized on the same principles as the Janus JS. I will try to fit this in, any guideline you prefer I follow?

I think working on the unified plan transition will your package much more useful since it is an infrastructure improvement.

@shivanshtalwar0
Copy link
Collaborator

Yes organization is different since janus js needs to support multiple browsers but working principle is same and i agree unified support is much needed for project like this just follow along same janusjs examples for each plugin in order to develop multistreaming support in case of any doubt feel free to reach out to me at shivanshtalwar0@gmail.com

@shivanshtalwar0
Copy link
Collaborator

For development purpose you could use
Rest Multistream https://janus.onemandev.tech/mjanus
Websocket Multistream
https://janus.onemandev.tech/mjanus/websocket

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants