Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type safety for "loadFlow" function when using the extension #115

Open
GabiGrin opened this issue Apr 12, 2024 · 0 comments
Open

Type safety for "loadFlow" function when using the extension #115

GabiGrin opened this issue Apr 12, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers priority: high

Comments

@GabiGrin
Copy link
Contributor

loadFlow receives a string that isn't type-safe, leading to possible annoying errors such as typos or loadFlow not failing when .flyde files were moved around (#112 ?)

Also, adding type safety to the inputs and outputs of a flow is very valuable.

For any future contributor who wants to take a look:
There's already some attempt I've made to do this - see https://github.com/flydelabs/flyde/blob/main/dev-server/src/service/generate-typings.ts (dev-server is the module used by the vs-code extension)

@GabiGrin GabiGrin added enhancement New feature or request good first issue Good for newcomers priority: high labels Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers priority: high
Projects
None yet
Development

No branches or pull requests

1 participant