New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an user setting that enables or disables notifications from accounts the user follows #20533
Comments
Thanks for the issue, we will take it into consideration! Our team of engineers is busy working on many types of features, please give us time to get back to you. To our amazing contributors: issues labeled If this is a feature request from an external contributor (not core team at Forem), please close the issue and re-post via GitHub Discussions. To claim an issue to work on, please leave a comment. If you've claimed the issue and need help, please ping @forem-team. The OSS Community Manager or the engineers on OSS rotation will follow up. For full info on how to contribute, please check out our contributors guide. |
@PhilipHow if you are working on it, i'm happy to help. either dividing up the work, or helping with testing. I've been asking for this for a while. |
@tonymet Are you free to take it on? If so, then I can assist. I won't be getting to this for a week or so. |
I'll review the code this weekend and try to scope out the effort . Here's my guess not knowing much about the code
Assuming dev env setup and the code points for the above are pretty clear, i'm happy to partner with you on it. |
I started marking up the codepoints needing changes here : https://github.com/forem/forem/compare/main...tonymet:forem:new-post-notification-setting?expand=1 Take a look and let me know if you're up to dividing the work. I'll continue at a slow pace over the next week or so |
I got a workign proof of concept on the branch above You can test it out with
Then visit http://localhost:3000/notifications and notice the new-post notifs are gone. What is Done
What is next
|
@PhilipHow can you take a look at the PR and share your feedback? it's ~ 85% complete |
Is this feature related to a problem? Please describe.
Describe the solution you’d like
/settings/notifications
which enables or disables any notifications being sent when an article is published from accounts the user follows.Additional Context
#15328
The text was updated successfully, but these errors were encountered: