Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix displayed article comment counts (take into account comments hidden after the author is assigned spam) #20621

Closed
PhilipHow opened this issue Feb 13, 2024 · 2 comments · Fixed by #20960
Assignees
Labels
bug always open for contribution

Comments

@PhilipHow
Copy link
Contributor

PhilipHow commented Feb 13, 2024

Describe the bug

Article comment counts are not updating when comment authors are being applied with the spam role.

To Reproduce

  • Find an article with multiple comments
  • Apply spam role to one of the comment authors
  • Wait for any caches to be invalidated
  • Comment is hidden, but comment count remains the same.

Expected behavior

The comment count should show the number of visible comments on the article (i.e. not counting those from users applied with spam).

Screenshots

image

Additional context

  • We may not want to update the actual comment count, but dynamically calculate the actual number of displayed comments.
@PhilipHow PhilipHow added the bug always open for contribution label Feb 13, 2024
Copy link
Contributor

Thanks for the issue, we will take it into consideration! Our team of engineers is busy working on many types of features, please give us time to get back to you.

To our amazing contributors: issues labeled bug are always up for grabs, but for feature requests, please wait until we add a ready for dev before starting to work on it.

If this is a feature request from an external contributor (not core team at Forem), please close the issue and re-post via GitHub Discussions.

To claim an issue to work on, please leave a comment. If you've claimed the issue and need help, please ping @forem-team. The OSS Community Manager or the engineers on OSS rotation will follow up.

For full info on how to contribute, please check out our contributors guide.

@PhilipHow PhilipHow changed the title Update article comment counts when a comment author is assigned spam Update displayed article comment counts when a comment author is assigned spam Feb 13, 2024
@lightalloy lightalloy changed the title Update displayed article comment counts when a comment author is assigned spam Fix displayed article comment counts (take into account comments hidden after the author is assigned spam) Feb 13, 2024
@lightalloy
Copy link
Contributor

I think, the count in the "View full discussion (n comments)" was not updated, so may show wrong number in some cases.
Other places should be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug always open for contribution
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants