Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Preview" does not work when replying to a comment #20681

Open
moopet opened this issue Feb 27, 2024 · 8 comments
Open

"Preview" does not work when replying to a comment #20681

moopet opened this issue Feb 27, 2024 · 8 comments
Labels
bug always open for contribution

Comments

@moopet
Copy link

moopet commented Feb 27, 2024

Describe the bug

The "preview" button does not work when replying to a comment.
In the console we see:

Uncaught ReferenceError: handleCommentPreview is not defined
onclick https://dev.to/moopet/comment/2d7ei:1

To Reproduce

  1. Open any post
  2. Enter some text in a reply to a comment
  3. Hit "preview" instead of "submit"

Expected behavior

We see some sort of preview of the markdown, either in-place or as a separate interstitial page.

Screenshots

Desktop (please complete the following information):

  • OS, version: Windows 11
  • Browser, version: Firefox 122.01

Additional context

This is a continuation of #19290 which was closed with only a partial fix last year.

@moopet moopet added the bug always open for contribution label Feb 27, 2024
Copy link
Contributor

Thanks for the issue, we will take it into consideration! Our team of engineers is busy working on many types of features, please give us time to get back to you.

To our amazing contributors: issues labeled bug are always up for grabs, but for feature requests, please wait until we add a ready for dev before starting to work on it.

If this is a feature request from an external contributor (not core team at Forem), please close the issue and re-post via GitHub Discussions.

To claim an issue to work on, please leave a comment. If you've claimed the issue and need help, please ping @forem-team. The OSS Community Manager or the engineers on OSS rotation will follow up.

For full info on how to contribute, please check out our contributors guide.

@GwartneyDev
Copy link
Contributor

@moopet This seems to be a similar issue, but wanted to check, does it look something like this #20701

@moopet
Copy link
Author

moopet commented Mar 1, 2024

@GwartneyDev no, it's not like that - in this case you can't even get to the preview in the first place. It looks like the library used for previewing things isn't loaded unless you have a post to edit already (speculation).

@GwartneyDev
Copy link
Contributor

@moopet Ah ok that is weird, will have to see if I can test it on my side at some point. Just figured I would ask in general since the other one just seemed similar.

@Link2Twenty
Copy link
Contributor

I'm unable to replicate the issue, has it been solved?

@GwartneyDev
Copy link
Contributor

Just following up to see if this was ever solved?

@moopet
Copy link
Author

moopet commented Mar 13, 2024

This is still a problem, and I still see "handleCommentPreview is not defined" in the console in Chrome and Firefox.

@morfenza
Copy link
Contributor

This seems to be similar to #20389, @joaoGabriel55 opened an PR to solve it! #20394

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug always open for contribution
Projects
None yet
Development

No branches or pull requests

4 participants