Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Add Spanish and French l10n #267

Closed
wants to merge 16 commits into from
Closed

[feat] Add Spanish and French l10n #267

wants to merge 16 commits into from

Conversation

opxdelwin
Copy link
Contributor

@opxdelwin opxdelwin commented Mar 9, 2024 •
edited

PR Description

This PR introduces a new feature to APIDash, allowing users to switch between English, Spanish, and French languages for the interface. Users can now select their preferred language and save it as their default setting in the settings page.

By default English has been set to fallback language.

Used Google translate for translation, did verify the reverse to get an accurate translation. Will prefer a native speaker's confirmation over the top as well.

Related Issues

Checklist

  • Reverse translate to verify integrity of sentences.
  • Add l10n dependency for tests
  • I have gone through the contributing guide
  • I have run the tests (flutter test) and all tests are passing

Added/updated tests?

We encourage you to add relevant test cases.

  • Yes
  • No, and this is why: Not sure if l10n needs tests. Will add if required.

@opxdelwin
Copy link
Contributor Author

I've updated major parts of the UI, just fixed old tests and added localization for all MaterialApps within them. I have like 4 tests failing on my machine, probably due to my copy of Flutter, please do verify accordingly.

If there's any part of UI that I've missed on translation, do let me know. There seems to be one or so in ResponsePane side of things, please do have a look :)

Awaiting initial feedback.

@animator
Copy link
Member

Hi @opxdelwin Kindly raise an issue and link this PR to it.
Thanks.

@animator
Copy link
Member

@opxdelwin The english strings should have been as it is .. why have you modified them without informing us or mentioning in this PR?
Few Examples:

  • kLabelAddKey: " Add Key" -> "Add Key"
  • kLabelAddValue: " Add Value" -> "Add Value"
  • kLabelAPIHeaderName: "Add Header Name" -> "Header Name"
  • kLabelAPIHeaderValue: “ Add Header Value" -> "Header Value"
  • kLabelAddURLParameters: "Add URL Parameter" -> "Add Parameters"

& many more

@opxdelwin
Copy link
Contributor Author

Thanks for pointing this out, my apologies for the overlook, I've been engaged for a while hence didn't get time to comprehensively recheck. I'll ping you once done.
Along with this, in translations, few of them have been affected in a similar way such as

  • home -> House (spanish) ; changed to "home page" in PR to get appropriate translation.

what changes should I do to these?

@animator
Copy link
Member

Closing this PR as this feature will require a bit more structure, pre-planning & native language speakers for implementation.

@animator animator closed this Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feat] Implement Spanish and French Language Support
2 participants
@opxdelwin @animator