Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change types of field in Share Balance #39891

Open
tinodj opened this issue Feb 13, 2024 · 0 comments · May be fixed by #41528
Open

Change types of field in Share Balance #39891

tinodj opened this issue Feb 13, 2024 · 0 comments · May be fixed by #41528
Labels
bug

Comments

@tinodj
Copy link

tinodj commented Feb 13, 2024

Information about bug

rate and amount should be currency and not int.

erpnext/erpnext/accounts/doctype/share_balance/share_balance.json

Line 202 in 22291d3

"fieldtype": "Int",

erpnext/erpnext/accounts/doctype/share_balance/share_balance.json

Line 83 in 22291d3

"fieldtype": "Int",

Module

accounts

Version

latest

Installation method

None

Relevant log output / Stack trace / Full Error Message.

No response
@tinodj tinodj added the bug label Feb 13, 2024
tinodj added a commit to tinodj/erpnext that referenced this issue Feb 13, 2024
@tinodj
Update share_balance.json
4ab435c 
fix frappe#39891

rate and amount should be Currency and not Int.
@tinodj tinodj mentioned this issue Feb 13, 2024
Closed
@tinodj tinodj mentioned this issue Mar 27, 2024
Closed
@tinodj tinodj linked a pull request May 17, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
1 participant
@tinodj