Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated UI for landing page #54680

Open
jdwilkin4 opened this issue May 6, 2024 · 7 comments
Open

Updated UI for landing page #54680

jdwilkin4 opened this issue May 6, 2024 · 7 comments
Labels
scope: UI Threads for addressing UX changes and improvements to user interface status: discussing Under discussion threads. Closed as stale after 60 days of inactivity. type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc.

Comments

@jdwilkin4
Copy link
Contributor

Describe the Issue

On main, I can see there have been updates to better show the progression for the core curriculum. And I think it looks like nice.

Screenshot 2024-05-06 at 2 22 12 PM

But when it comes to the other courses, like the C# courses and the interview prep section, I feel like it would be better to remove the circles. At first I thought I was supposed to click on these circles because they looked like buttons to me.

Screenshot 2024-05-06 at 2 23 22 PM

Affected Page

http://localhost:8000/

Steps to Reproduce

These changes are only available on the localhost. So you will need to run it locally to see what I am referring to.

  1. Go to http://localhost:8000/
  2. scroll down to the extra courses outside of the core curriculum and see what I am referring to

Expected behavior

For courses, like odin project, interview prep, C#, etc, I don't think these circles need to be here

Screenshot 2024-05-06 at 2 26 18 PM

It would be better to leave it to the original like this
Screenshot 2024-05-06 at 2 26 43 PM

As for the english curriculum, if new courses will be added there then maybe it works to have progression like is shown for the core curriculum.

Screenshots

No response

System

  • Device: [e.g. iPhone 6, Laptop]
  • OS: [e.g. iOS 14, Windows 10, Ubuntu 20.04]
  • Browser: [e.g. Chrome, Safari]
  • Version: [e.g. 22]

Additional context

No response

@jdwilkin4 jdwilkin4 added type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc. status: waiting triage This issue needs help from moderators and users to reproduce and confirm its validity and fix. labels May 6, 2024
@jdwilkin4 jdwilkin4 changed the title Questions about updated UI for landing page Updated UI for landing page May 6, 2024
@gikf gikf added the scope: UI Threads for addressing UX changes and improvements to user interface label May 7, 2024
@gikf
Copy link
Member

gikf commented May 7, 2024

This seems to be related with #54656

@deeseeker
Copy link

deeseeker commented May 7, 2024

I would like to give this a shot. Please assign the task to me.

@moT01
Copy link
Member

moT01 commented May 7, 2024

A couple things to note here...

The circles have four states. Empty, all challenges completed (filled-in), certification earned (ribbon added), both (filled-in and certification earned). See some images here.

I agree that they look a little goofy beyond the core curriculum, but we kept them because the buttons become full width if we remove them - and that looks a little goofy too. I think it would look good enough, but the C# (and soon English), have certifications to claim, as well as some of the legacy. So it's nice to show the circles or something on those so people can see that they earned the cert - as well as have something to motivate them.

I definitely think there's room for improvement here. I'm not sure what the solution is though. I would probably be fine removing all the circles that aren't the core curriculum if we want - but maybe we could play around with a few other designs. Maybe make all the circles gray or something, so they don't look clickable? Add an icon in the circles without a number?

If anyone wants to come up with some mocks or play with some designs and share - that could help.

@moT01 moT01 added status: discussing Under discussion threads. Closed as stale after 60 days of inactivity. and removed status: waiting triage This issue needs help from moderators and users to reproduce and confirm its validity and fix. labels May 7, 2024
@jdwilkin4
Copy link
Contributor Author

Hi @deeseeker !

This issue has not been opened up for contribution.
Issues marked with help wanted or first timers only are available for contribution.
You can read about the contributing process here

@jdwilkin4
Copy link
Contributor Author

@moT01

The circles have four states. Empty, all challenges completed (filled-in), certification earned (ribbon added), both (filled-in and certification earned)

Ok cool. Thanks for clarifying that.
Looking at the image I like the final result there.

@AdityaRaj150
Copy link

why can't the odin project-coding interview prep -so on all have numbers 1,2- so on insider their circles just like the other courses and can have same animation then. since a circle having number inside definitely doesn't look clickable but a task to complete and filling it with colours does show that the task has been completed.

@deeseeker
Copy link

@jdwilkin4 Thanks for the feedback. I will check it out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: UI Threads for addressing UX changes and improvements to user interface status: discussing Under discussion threads. Closed as stale after 60 days of inactivity. type: bug Issues that need priority attention. Platform, Curriculum tests (if broken completely), etc.
Projects
None yet
Development

No branches or pull requests

5 participants