-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add team counter to home page #2147
Conversation
[frontend] [Sat May 18 04:32:08 UTC 2024] - Deployed d9517f2 to https://genshin-optimizer-prs.github.io/pr/2147/frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Sat May 18 05:26:58 UTC 2024] - Deployed de1d8e3 to https://genshin-optimizer-prs.github.io/pr/2147/frontend (Takes 3-5 minutes after this completes to be available) [frontend] [Tue May 21 05:20:56 UTC 2024] - Deployed 368e297 to https://genshin-optimizer-prs.github.io/pr/2147/frontend (Takes 3-5 minutes after this completes to be available) [Wed May 22 01:45:13 UTC 2024] - Deleted deployment |
/> | ||
<Chip | ||
sx={{ flexGrow: 1, cursor: 'pointer' }} | ||
color={numBuilds ? 'success' : 'secondary'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we start using less colors here? Or are you gonna do that in a different pr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably a different PR, will def need more design guidance before pulling the trigger on that.
"archive": "Archive" | ||
"archive": "Archive", | ||
"loadouts": "Loadouts", | ||
"builds": "Builds" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically not a tab, but I'll allow it
Describe your changes
Issue or discord link
Testing/validation
Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)
yarn run mini-ci
locally to validate format and lint.