Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add team counter to home page #2147

Merged
merged 4 commits into from
May 22, 2024
Merged

add team counter to home page #2147

merged 4 commits into from
May 22, 2024

Conversation

frzyc
Copy link
Owner

@frzyc frzyc commented May 18, 2024

Describe your changes

Issue or discord link

Testing/validation

Screenshot 2024-05-18 002549

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • I have run yarn run mini-ci locally to validate format and lint.
  • If I have added a new library or app, I have updated the deployment scripts to ignore changes as needed

@frzyc frzyc requested a review from nguyentvan7 May 18, 2024 04:28
Copy link
Contributor

github-actions bot commented May 18, 2024

[frontend] [Sat May 18 04:32:08 UTC 2024] - Deployed d9517f2 to https://genshin-optimizer-prs.github.io/pr/2147/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Sat May 18 05:26:58 UTC 2024] - Deployed de1d8e3 to https://genshin-optimizer-prs.github.io/pr/2147/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Tue May 21 05:20:56 UTC 2024] - Deployed 368e297 to https://genshin-optimizer-prs.github.io/pr/2147/frontend (Takes 3-5 minutes after this completes to be available)

[Wed May 22 01:45:13 UTC 2024] - Deleted deployment

libs/gi/page-home/src/InventoryCard.tsx Outdated Show resolved Hide resolved
/>
<Chip
sx={{ flexGrow: 1, cursor: 'pointer' }}
color={numBuilds ? 'success' : 'secondary'}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we start using less colors here? Or are you gonna do that in a different pr

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably a different PR, will def need more design guidance before pulling the trigger on that.

@frzyc frzyc requested a review from nguyentvan7 May 21, 2024 05:18
"archive": "Archive"
"archive": "Archive",
"loadouts": "Loadouts",
"builds": "Builds"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically not a tab, but I'll allow it

@frzyc frzyc merged commit 69be853 into master May 22, 2024
6 checks passed
@frzyc frzyc deleted the 2141 branch May 22, 2024 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Team counter to Home page
2 participants