Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "character editor" to TC Build editor #2154

Closed
frzyc opened this issue May 20, 2024 · 2 comments · Fixed by #2160
Closed

Add a "character editor" to TC Build editor #2154

frzyc opened this issue May 20, 2024 · 2 comments · Fixed by #2160

Comments

@frzyc
Copy link
Owner

frzyc commented May 20, 2024

Likely will fulfill #2144
For people who theorycraft different builds under different conditions, it makes sense to assume a specific character level/talent/constellation.

Workbreakdown:

  • Add character data to TC builds
  • Add Character editor to TC editor/overview
  • Add additional logic for useTeamData for overriding the character data from buildTC
  • Add comparable fields (level/talent/constellation) to show on build results when comparing two builds with different character data
  • Likely have to account for comparing results of nodes that may or may not show in comparable builds (like nodes hidden behind constellation)
  • Add character data to TC builds when converting build to TC builds
@nguyentvan7
Copy link
Collaborator

Is it in scope to include this for real builds too?

my use case is determining if a constellation or weapon is 'worth' to pull. Weapons are covered since you can save multiple builds.

Constellation editing in TC builds is nice (and good for team sharing), but doesn't cover me wanting to optimize with my own artifacts to compare.

I understand its a lot of work to add it in general, so just checking

@frzyc
Copy link
Owner Author

frzyc commented May 20, 2024

No, adding this to real builds will potentially break the "plug and play" versatility of loadouts,(and subsequently team exim) I am not sure if I want to cover the usecase of "is something i don't have worth" in terms of a "real build" workflow officially, I think being able to address it and compare in TC build is probably good enough for most cases. and we can maintain the "real builds are real" assumption going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants