Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Remove Engine composition #457

Open
goodwanghan opened this issue Apr 5, 2023 · 0 comments
Open

[FEATURE] Remove Engine composition #457

goodwanghan opened this issue Apr 5, 2023 · 0 comments

Comments

@goodwanghan
Copy link
Collaborator

We are able to combine an execution engine with a sql engine for example

native+duckdb

would use native execution engine + duckdb sql engine.

But now

  1. different sql engines can be used inside any FugueWorkflow (CONNECT in Fugue SQL)
  2. ExecutionEngine now consists of multiple components: SQLEngine, MapEngine, etc. The current expression using + only works to overwrite SQLEngine which no longer makes sense
  3. This feature is rarely used

So in order to keep things simple, we should remove this feature. We may add back when there is a better design.

@goodwanghan goodwanghan added this to the 0.8.4 milestone Apr 5, 2023
@goodwanghan goodwanghan removed this from the 0.8.4 milestone May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant