New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking change between V10 & V11, incompatibility with google API (gapi) Promises #149

Open

milelo opened this issue Jan 18, 2024 · 0 comments

milelo commented Jan 18, 2024 •

edited

I'm trying to upgrade from
[funcool/promesa "10.0.594"]
to
[funcool/promesa "11.0.678"]

The latter isn't compatible with google api promises, they are no longer recognised by promesa as promises:

https://google.github.io/closure-library/api/goog.Thenable.html
https://github.com/google/google-api-javascript-client

As a work around I'm using an adaptor that resolves the issue:

(defn $promise [gapi-promise]
  (p/create (fn [resolve reject]
              (-> gapi-promise
                  (.then resolve)
                  (.catch reject)))))

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment