Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For u64 and i128/u128 types, use BigInt in the Dart side. #1934

Closed
iota9star opened this issue May 13, 2024 · 3 comments · Fixed by #1964
Closed

For u64 and i128/u128 types, use BigInt in the Dart side. #1934

iota9star opened this issue May 13, 2024 · 3 comments · Fixed by #1964
Labels
enhancement New feature or request

Comments

@iota9star
Copy link

iota9star commented May 13, 2024

Is your feature request related to a problem? Please describe.

In version 2.0.0-dev.33, the Dart code generated for u64 uses int, but the value range of u64 exceeds that of Dart's int. As for i128/u128 types, there's no available type in Dart. I think using BigInt in Dart could be a good solution.

image

@iota9star iota9star added the enhancement New feature or request label May 13, 2024
@fzyzcjy
Copy link
Owner

fzyzcjy commented May 14, 2024

Looks reasonable, and feel free to PR for this! Alternatively I will try to find time to fix it later.

P.S. usize may also be considered the same as u64

@iota9star
Copy link
Author

@fzyzcjy Do you have plans to release a new version in the next couple of days?

@fzyzcjy
Copy link
Owner

fzyzcjy commented May 25, 2024

Sure! Hopefully within a day, because I want to finish some other PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants