Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong filename in titlebar after launch #3684

Open
techee opened this issue Nov 13, 2023 · 5 comments · May be fixed by #3891
Open

Wrong filename in titlebar after launch #3684

techee opened this issue Nov 13, 2023 · 5 comments · May be fixed by #3891
Labels
bug
Milestone
2.1

Comments

@techee
Copy link
Member

techee commented Nov 13, 2023

After Geany launch a filename not corresponding to the current file is shown in the title bar - see the screenshot below. It gets fixed as active document changes. I'm wondering if something similar to #3609 should be also done for the titlebar.

Screenshot 2023-11-13 at 10 58 18
@techee techee added the bug label Nov 13, 2023
@techee techee mentioned this issue Nov 22, 2023
Open
@techee
Copy link
Member Author

techee commented Nov 22, 2023

Note that his happens when the first tab is selected after opening a session - apparently "document-open" signal isn't invoked in this case. This is a problem for the LSP plugin too: techee/geany-lsp#30.

@techee
Copy link
Member Author

techee commented Nov 22, 2023

apparently "document-open" signal isn't invoked in this case

Sorry, I meant "document-activate".

@elextr elextr mentioned this issue Dec 1, 2023
Closed
@techee
Copy link
Member Author

techee commented Dec 1, 2023

There's one more problem, the MRU file list isn't updated either when the first tab is selected after Geany start so when you switch to another tab and want to go back, the first tab's document isn't in the MRU list.

@techee techee added this to the 2.1 milestone Apr 28, 2024
@techee
Copy link
Member Author

techee commented Apr 28, 2024

I've bisected this to #3267. The original code contained the switch_to_session_page() function which emitted the switch-page signal even in the case when the right tab was already selected (so no real switch happened) which then lead to correct "document-activate" emission from on_notebook1_switch_page_after().

@techee
Copy link
Member Author

techee commented May 5, 2024

Another victim of this problem is the git-changebar plugin (and possibly others) that expects that "document-activate" is delivered also when a single tab is open. The result is that when no document is open and you open some document with changes against the committed state, git-changebar doesn't show the changes.

@techee techee mentioned this issue May 10, 2024
Open
techee added a commit to techee/geany that referenced this issue May 11, 2024
@techee
Fix emission of document-activate signal and various related GUI glit…
3ccd8fb 
…ches

PR geany#3267 removed the special handling
of the situation when no tab change happens after setting an active
document after session load. This happens in the situation where

1. There's just a single document
2. Depending on the tab opening logic, the active tab saved into the session
   file corresponds to the already active tab

This patch tries to restore the previous behavior where switch-page" was
synthetically emitted in such situations.

Fixes geany#3684.
@techee techee mentioned this issue May 11, 2024
Closed
b4n added a commit to b4n/geany that referenced this issue Jun 1, 2024
@b4n
Fix emission of document-activate signal and associated UI glitches
6e1cbed 
PR geany#3267 broke handling of several
special tab switch cases:

* By showing the tab's child too early, it prevented the switch-page
  handler to properly work in situations where there was only one page,
  as the tab switch would happen at page creation yet the document
  would not be valid yet.
* It removed explicit emission of the switch-page signal when the
  source and target pages are the same after session opening, which
  happens if the active session page is the first one.

Fix this by mostly reverting 23367de
and implementing the delay directly in the switch-page handler.

Fixes geany#3684.
@b4n b4n linked a pull request Jun 1, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.1
1 participant
@techee