Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

seems that this condition is restrictive. I don't see a reason why we need to limit the majority class to never be smaller@georgemilosh #52

Open
georgemilosh opened this issue Jan 30, 2023 · 2 comments
Open

seems that this condition is restrictive. I don't see a reason why we need to limit the majority class to never be smaller@georgemilosh #52

georgemilosh opened this issue Jan 30, 2023 · 2 comments
Assignees
@georgemilosh
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@georgemilosh
Copy link
Owner

Climate-Learning/PLASIM/Learn2_new.py

Line 1298 in ca9d088

if undersampling_strategy > 1: # you cannot undersample so much that the majority class becomes the minority one

@georgemilosh georgemilosh self-assigned this Jan 30, 2023
@georgemilosh georgemilosh added bug Something isn't working enhancement New feature or request and removed bug Something isn't working labels Jan 30, 2023
@AlessandroLovo
Copy link
Collaborator

I think there was potentially a problem with passing the RandomUnderSampler if you gave it a number bigger than 1. Not sure though

@georgemilosh
Copy link
Owner Author

Yes I think you are right

@AlessandroLovo AlessandroLovo added the wontfix This will not be worked on label Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@georgemilosh georgemilosh

Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AlessandroLovo @georgemilosh