Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the default behavior should be to load from a repository config file which documents where to look for the data #65

Open
georgemilosh opened this issue Mar 2, 2023 · 8 comments
Labels
enhancement New feature or request

Comments

@georgemilosh
Copy link
Owner

self.datas = xr.open_dataset(ut.first_valid_path(self.mylocal,self.filename))

@georgemilosh georgemilosh added enhancement New feature or request wontfix This will not be worked on labels Mar 2, 2023
@AlessandroLovo
Copy link
Collaborator

Can you please elaborate on this?

@georgemilosh
Copy link
Owner Author

Basically as I started working from other clusters, the default path doesn't seem to be reasonable. Thus there is no reason to hard-code it inside the Learn2_new.py, that is to say, its default value doesn't make sense outside of CBP or if anyone else outside would use our software. So I would recommend having a separate json file that just contains the default folder. Default name could be the name of that json file for example.

@AlessandroLovo
Copy link
Collaborator

Ok this makes sense

@AlessandroLovo
Copy link
Collaborator

Now that we want to work with Reanalysis data as well this seems even more important

@AlessandroLovo AlessandroLovo removed the wontfix This will not be worked on label May 9, 2023
@georgemilosh
Copy link
Owner Author

So you are not happy with my CESM hack? See CESM_tuto.ipynb

@AlessandroLovo
Copy link
Collaborator

On the contrary, I do like it. But it is indeed a hack. At some point we should make things more natural maybe.
With Valeria we wanted to use the Reanalysis data, but right now all the interface (for Plasim and CESM) is hardcoded in Learn2_new and ERA_Fields_New.
So, maybe, this is a good time to make things nicer.
However, it's faster to just make another hack like yours, so we'll likely go for this approach for the moment 🥲

@georgemilosh
Copy link
Owner Author

Well you have evaluate how much time you both have and prioritise what is important for you. Having pretty repo is nice, but it should also be not overly complex to be comprehended in case something needs to be changed.

@AlessandroLovo
Copy link
Collaborator

Indeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants