Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PIPY and update README #115

Merged
merged 4 commits into from Apr 3, 2024
Merged

Add PIPY and update README #115

merged 4 commits into from Apr 3, 2024

Conversation

truskovskiyk
Copy link
Contributor

No description provided.

@benjaminye
Copy link
Contributor

@truskovskiyk @RohitSaha

I would also make llmtune as the entry point for running the CLI. Instead of doing python toolkit.py --config-path config.yaml, users can just do llmtune --config-path config.yaml. We can also add a pipx installation instruction so CLI lives in an isolated virtual environment.

I have made the following changes in my local machine and can verify it works.

  1. Move toolkit.py into llmtune/cli/tookit.py
  2. Modify the entrypoint in toolkit.py
- if __name__ == "__main__":
-     app()

+ def cli():
+     app()
  1. Add script entry point in pyproject.toml
+ [tool.poetry.scripts]
+ llmtune = "llmtune.cli.toolkit:cli"

Copy link
Contributor

@benjaminye benjaminye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Please take a look at comment #115.

Also, any reason of using twine vs poetry publish?

@benjaminye
Copy link
Contributor

Related: #108

@benjaminye benjaminye linked an issue Apr 3, 2024 that may be closed by this pull request
@truskovskiyk
Copy link
Contributor Author

Looks good! Please take a look at comment #115.

Also, any reason of using twine vs poetry publish?

agree, poetry publish is much better, updated

@truskovskiyk
Copy link
Contributor Author

@truskovskiyk @RohitSaha

I would also make llmtune as the entry point for running the CLI. Instead of doing python toolkit.py --config-path config.yaml, users can just do llmtune --config-path config.yaml. We can also add a pipx installation instruction so CLI lives in an isolated virtual environment.

I have made the following changes in my local machine and can verify it works.

  1. Move toolkit.py into llmtune/cli/tookit.py
  2. Modify the entrypoint in toolkit.py
- if __name__ == "__main__":
-     app()

+ def cli():
+     app()
  1. Add script entry point in pyproject.toml
+ [tool.poetry.scripts]
+ llmtune = "llmtune.cli.toolkit:cli"

good idea, please create issue

@truskovskiyk truskovskiyk merged commit e958635 into main Apr 3, 2024
3 checks passed
@truskovskiyk truskovskiyk deleted the add-pipy-package branch April 3, 2024 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a Makefile to simplify the execution of tests, styling, and other Bash commands. Add pipy package.
2 participants