Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug with features reset date, they should always be generated after now. #61

Open
julienarcin opened this issue Oct 5, 2020 · 1 comment
Open

Bug with features reset date, they should always be generated after now. #61

julienarcin opened this issue Oct 5, 2020 · 1 comment

Comments

@julienarcin
Copy link

julienarcin commented Oct 5, 2020 •
edited

@gerardojbaez There is a bug with features reset dates. Reset dates should never be set before today.

If a user subscribes to a yearly plan, uses a feature monthly resettable feature in January, and uses it again on April, the code to regenerate the feature reset date is not correct. It will generate a reset date 1 month after on the first use, then regenerate the date 1 month after on the second use, etc.

I'm submitting the PR (with tests) now.
@julienarcin julienarcin mentioned this issue Oct 5, 2020
Open
@julienarcin julienarcin changed the title Bug with features reset date Bug with features reset date, they should always be generated after now. Oct 5, 2020
@gerardojbaez
Copy link
Owner

Hey @julienarcin, thanks for the report and the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@julienarcin @gerardojbaez