Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem creating node addon #2085

Open
gabrielmicko opened this issue Apr 21, 2024 · 2 comments
Open

Problem creating node addon #2085

gabrielmicko opened this issue Apr 21, 2024 · 2 comments

Comments

@gabrielmicko
Copy link

gabrielmicko commented Apr 21, 2024

npx cmake-js compile -T whisper-addon -B Release

info find VS using VS2022 (17.9.34728.123) found at:
info find VS "C:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools"
info find VS run with --verbose for detailed information
info TOOL Using Visual Studio 17 2022 generator.
info CMD BUILD
info RUN [
info RUN 'cmake',
info RUN '--build',
info RUN 'C:\Users\gabri\Documents\whsiperforvscode\whisper.cpp\build',
info RUN '--config',
info RUN 'Release',
info RUN '--target',
info RUN 'whisper-addon'
info RUN ]
MSBuild version 17.9.8+b34f75857 for .NET Framework
MSBUILD : error MSB1009: Project file does not exist.
Switch: whisper-addon.vcxproj
info REP Build has been failed, trying to do a full rebuild.
info CMD CLEAN
info RUN [
info RUN 'cmake',
info RUN '-E',
info RUN 'remove_directory',
info RUN 'C:\Users\gabri\Documents\whsiperforvscode\whisper.cpp\build'
info RUN ]
info CMD CONFIGURE
info find VS using VS2022 (17.9.34728.123) found at:
info find VS "C:\Program Files (x86)\Microsoft Visual Studio\2022\BuildTools"
info find VS run with --verbose for detailed information
info RUN [
info RUN 'cmake',
info RUN 'C:\Users\gabri\Documents\whsiperforvscode\whisper.cpp',
info RUN '--no-warn-unused-cli',
info RUN '-G',
info RUN 'Visual Studio 17 2022',
info RUN '-A',
info RUN 'x64',
info RUN '-DCMAKE_JS_VERSION=7.3.0',
info RUN '-DCMAKE_BUILD_TYPE=Release',
info RUN '-DCMAKE_RUNTIME_OUTPUT_DIRECTORY=C:\Users\gabri\Documents\whsiperforvscode\whisper.cpp\build',
info RUN '-DCMAKE_MSVC_RUNTIME_LIBRARY=MultiThreaded$<$CONFIG:Debug:Debug>',
info RUN '-DCMAKE_JS_INC=C:\Users\gabri\.cmake-js\node-x64\v18.16.0\include\node',
info RUN '-DCMAKE_JS_SRC=C:/Users/gabri/AppData/Local/npm-cache/_npx/df44183e4145658d/node_modules/cmake-js/lib/cpp/win_delay_load_hook.cc',
info RUN '-DNODE_RUNTIME=node',
info RUN '-DNODE_RUNTIMEVERSION=18.16.0',
info RUN '-DNODE_ARCH=x64',
info RUN '-DCMAKE_JS_LIB=C:\Users\gabri\.cmake-js\node-x64\v18.16.0\win-x64\node.lib',
info RUN '-DCMAKE_SHARED_LINKER_FLAGS=/DELAYLOAD:NODE.EXE'
info RUN ]
Not searching for unused variables given on the command line.
-- Selecting Windows SDK version 10.0.22621.0 to target Windows 10.0.22631.
-- The C compiler identification is MSVC 19.39.33523.0
-- The CXX compiler identification is MSVC 19.39.33523.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2022/BuildTools/VC/Tools/MSVC/14.39.33519/bin/Hostx64/x64/cl.exe - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2022/BuildTools/VC/Tools/MSVC/14.39.33519/bin/Hostx64/x64/cl.exe - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found Git: C:/Program Files/Git/cmd/git.exe (found version "2.40.0.windows.1")
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Failed
-- Looking for pthread_create in pthreads
-- Looking for pthread_create in pthreads - not found
-- Looking for pthread_create in pthread
-- Looking for pthread_create in pthread - not found
-- Found Threads: TRUE
-- CMAKE_SYSTEM_PROCESSOR: AMD64
-- x86 detected
CMake Error at examples/CMakeLists.txt:81 (set_target_properties):
set_target_properties Can not find target to add properties to: addon.node

Would someone please explain what I am doing wrong? Running this command from the project library (whisper.cpp).

@valVk
Copy link
Contributor

valVk commented Apr 24, 2024

The same issue here

trying to build node.addon@1.5.5 or node.addon@latest I'm getting the error above
the same command the same environment but node.addon@1.5.4 built without any errors

I'm not an expert but I think the problem somewhere here

set_target_properties(addon.node PROPERTIES FOLDER "examples")

@pprobst
Copy link
Contributor

pprobst commented Apr 28, 2024

#2091

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants