Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: emscripten builds are failing with Emscripten SDK 3.1.58 #2101

Closed
przemoc opened this issue Apr 28, 2024 · 1 comment
Closed

ci: emscripten builds are failing with Emscripten SDK 3.1.58 #2101

przemoc opened this issue Apr 28, 2024 · 1 comment

Comments

@przemoc
Copy link
Contributor

przemoc commented Apr 28, 2024

Error copying file "/home/runner/work/whisper.cpp/whisper.cpp/bin/libwhisper.worker.js" to "/home/runner/work/whisper.cpp/whisper.cpp/bindings/javascript/libwhisper.worker.js".

Looking at older passing vs newer failing runs, we may notice that Emscripten SDK version changed from 3.1.57 to 3.1.58. In ChangeLog for Emscripten SDK 3.1.58 we may see they refer to changes with handling of .worker.js, which may be the reason of the failure:

  • Multi-threaded builds no depend on a separate .worker.js file. This saves
    on code size and network requests. In order to make this change go smoothly,
    without breaking build systems that expect a worker.js, emscripten will
    generate an empty .worker.js to give folks time to transition their
    deployment scripts. In -sSTRICT mode, this empty file will not be
    generated. (#21701)

There seem to be various follow-up improvements to this change that will be part of 3.1.59, so delaying working on it may be the most efficient way to deal with this issue by whoever will want to fix it.

@przemoc
Copy link
Contributor Author

przemoc commented May 6, 2024

Recent run in CI is using Emscripten SDK 3.1.59, where issue is no longer observed.

@przemoc przemoc closed this as completed May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant