Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend market data with preset by activitiesCount and date #3006

Open
2 tasks
dtslvr opened this issue Feb 15, 2024 · 2 comments · May be fixed by #3022
Open
2 tasks

Extend market data with preset by activitiesCount and date #3006

dtslvr opened this issue Feb 15, 2024 · 2 comments · May be fixed by #3022
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@dtslvr
Copy link
Member

dtslvr commented Feb 15, 2024

Add missing attributes activitiesCount and date (First Activitiy) to market data endpoint for presetId = CURRENCIES (api/v1/admin/market-data?presetId=CURRENCIES).

Steps to reproduce

  1. Go to Admin Control
  2. Click on Market Data
  3. Select preset Currencies in Filter by...
market-data-with-currencies-preset

Todo

  • Set activitiesCount and date as required in AdminMarketDataItem interface (see here)
  • Add activitiesCount and date to getMarketDataForCurrencies() (see here)
@dtslvr dtslvr added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Feb 15, 2024
@bikash-789
Copy link

@dtslvr Can I work on this?

@bikash-789 bikash-789 linked a pull request Feb 18, 2024 that will close this issue
Open
@dtslvr dtslvr linked a pull request Feb 19, 2024 that will close this issue
Feat: Extended market data with preset by activitiesCount and date #3022
Open
@SirZemar
Copy link
Contributor

SirZemar commented Jun 1, 2024

Hey @dtslvr. If nobody is working on this and still open, I can have a go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat: Extended market data with preset by activitiesCount and date bikash-789/ghostfolio
3 participants
@dtslvr @bikash-789 @SirZemar