Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing manual CNAME file creation instructions #32930

Merged
merged 1 commit into from
May 24, 2024
Merged

Add missing manual CNAME file creation instructions #32930

merged 1 commit into from
May 24, 2024

Conversation

revolter
Copy link
Contributor

@revolter revolter commented May 13, 2024 •
edited

Why:

The previous documentation stated that a CNAME file is automatically created for you when deploying from a branch, but didn't explicitly mention that you have to create a CNAME file manually otherwise.

Closes: #32931

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

  • For content changes, I have completed the self-review checklist.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label May 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
pages/configuring-a-custom-domain-for-your-github-pages-site/managing-a-custom-domain-for-your-github-pages-site.md fpt
ghec
 fpt
ghec

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@revolter revolter changed the title Add missing manual CNAME file creation instructions Add missing manual CNAME file creation instructions May 13, 2024
@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review pages Content related to GitHub Pages and removed triage Do not begin working on this issue until triaged by the team labels May 13, 2024
@nguyenalex836
Copy link
Contributor

@revolter Thanks so much for opening a PR! I'll get this triaged for review ✨

@sophietheking sophietheking self-requested a review May 24, 2024 13:42
sophietheking
sophietheking approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@sophietheking sophietheking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@revolter 👋 Thanks for opening this PR and contributing to our Docs! This change looks good to me, so I'll go ahead and get this merged. 🚀

@sophietheking sophietheking added this pull request to the merge queue May 24, 2024
Merged via the queue into github:main with commit f2dee33 May 24, 2024
81 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@revolter revolter deleted the patch-2 branch May 26, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sophietheking sophietheking sophietheking approved these changes

Assignees
No one assigned
Labels
content This issue or pull request belongs to the Docs Content team pages Content related to GitHub Pages waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add missing manual CNAME file creation instructions
3 participants
@revolter @nguyenalex836 @sophietheking